Removing encrypted storage and attestation-cli #795
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tation-cli version to new that don't have rust dependencies
…e-caff-node Refactor /release-tee caff-node
Zaptoss
requested review from
ImJeremyHe,
Sneh1999,
alysiahuggins,
jbearer,
jjeangal,
sveitser and
zacshowa
as code owners
|
|
Sneh1999
reviewed
Oct 3, 2025
cmd/util/enclave.go
Outdated
| if err := os.MkdirAll(enclaveWalletPath, 0o700); err != nil { | ||
| return nil, err | ||
| } | ||
| kmsKeyIDPath := path.Join(enclaveWalletPath, kmsKeyIDFile) |
There was a problem hiding this comment.
I think for us its better to keep this code because we are not using all the utilities from github.com/distributed-lab/enclave-extras/nitro. So instead of deleting this, we should just remove the use of github.com/distributed-lab/enclave-extras/nitro from the repo
…enclave-extras/nitro package
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #<ISSUE_NUMBER>
This PR:
This PR does not:
Key places to review: