feat: build individual docker images locally #3309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for faster iterations on local docker builds.
Check if this speeds up the slow cross compiled builds in the CI.
This reverts commit 72054d9.
- feat: support single image build with optimized compilation - maintain backwards compatibility: without arguments we still build everything. - feat: option to clean - fix: avoid installing rust toolchain when starting cargo build in container - feat: allow compiling with profiles other than --release, here the *default is changed* to use the new `test-docker` profile since release builds are very slow and rarely needed for local development. - test: add test script to test some invocations of the build script.
sveitser
changed the title
sveitser
requested review from
jbearer,
tbro,
imabdulbasit,
ss-es,
pls148,
bfish713,
rob-maron and
lukaszrzasik
as code owners
| scripts/build-docker-images-native | ||
|
|
||
| # build only the deploy image | ||
| scripts/build-docker-images-native --image deploy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
everything.
container
default is changed to use the new
test-dockerprofile sincerelease builds are very slow and rarely needed for local development.
The new profile is needed because without stripping the sequencer
image is 4.5 GB instead of 1.5 GB.
How to test
These scripts are currently not run on the CI. To see if it's working locally:
scripts/build-docker-images-native --helpand try some invocations.scripts/test-build-docker-images-native, be aware it does acleanthe end.