Fix view sync across restarts #3279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pls148
reviewed
May 14, 2025
| CREATE TABLE restart_view ( | ||
| -- The ID is always set to 0. Setting it explicitly allows us to enforce with every insert or | ||
| -- update that there is only a single entry in this table: the view we should restart from. | ||
| id INT PRIMARY KEY, |
There was a problem hiding this comment.
can do INTEGER PRIMARY KEY CHECK (id = 0) to enforce this
There was a problem hiding this comment.
Keeping this the same since this pattern is already in use
bfish713
requested review from
sveitser,
jbearer,
tbro,
imabdulbasit,
ss-es,
rob-maron and
lukaszrzasik
as code owners
lukaszrzasik
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #<ISSUE_NUMBER>
This PR:
This PR does not:
Key places to review: