-
Notifications
You must be signed in to change notification settings - Fork 432
Add argument to set temporary directory during CodeChecker store #4668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is breaking.
a02c61d
to
484affe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a nit.
help="Specify a path to use as temporary folder. " | ||
"Necessary to have a place to compress files before " | ||
"uploading them. Defaults to the result directory. " | ||
"Normally it isn't necessary to specify. " | ||
"Useful when the folder containing the result folder " | ||
"is read only.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specify the location to write the compressed file used for storage. Useful if the results directory is read only. Defaults to the results directory.
5114c59
to
2c292b1
Compare
5c31813
to
03030da
Compare
Why:
When working on Bezel, we encounter a situation where the result files are placed into a read-only folder. By default,
CodeChecker store
creates a temporary directory for zipping the results before sending them to the server. This directory cannot be created in a read-only folder, causing CodeChecker to crash.What:
This pull request adds an extra command-line argument,
--temp_dir
, to theCodeChecker store
command, which specifies where temporary files should be created. When this argument is not set, it continues to use the previous implementation.