Skip to content

[MLIR] Forward Mode arg conversion for dup -> const #2349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[MLIR] Forward Mode arg conversion for dup -> const #2349

wants to merge 4 commits into from

Conversation

vimarsh6739
Copy link
Member

@vimarsh6739 vimarsh6739 commented Jun 16, 2025 •
edited
Loading

@vimarsh6739 vimarsh6739 added forward mode Forward Mode AD reverse mode Reverse Mode AD mlir labels Jun 16, 2025
@vimarsh6739 vimarsh6739 changed the title [DO NOT MERGE] Input activity canonicalizations input activity canonicalization (dup to const) Jun 19, 2025
@vimarsh6739 vimarsh6739 requested a review from wsmoses June 19, 2025 00:10
@vimarsh6739 vimarsh6739 removed the reverse mode Reverse Mode AD label Jun 19, 2025
@vimarsh6739 vimarsh6739 marked this pull request as ready for review June 19, 2025 00:28
@vimarsh6739 vimarsh6739 changed the title input activity canonicalization (dup to const) [MLIR] Forward Mode arg conversion for dup -> const Jun 19, 2025
vimarsh6739 and others added 3 commits June 20, 2025 00:02
@vimarsh6739
Some cleanup
dd8ff11 
Signed-off-by: Vimarsh Sathia <[email protected]>
wsmoses
wsmoses reviewed Jun 20, 2025
View reviewed changes
enzyme/Enzyme/MLIR/Dialect/Ops.cpp
// selectively push or skip directional derivative
inp = uop.getInputs()[in_idx];
if (!isMutable(inp.getType()) &&
(matchPattern(inp, m_Zero()) ||
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avik-pal @Pangoraw do you remember the is zero we had set up [since this won't applies for complex as is]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it feels like this is worthwhile making into an interface for the type

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see https://github.com/EnzymeAD/Enzyme/pull/2355/files#diff-0a1e6c2523b1ed10a4bfba6f1a5208ba0eb2a444446c8fea0f653bf6a810719c for an example [notably getApproxSize]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsmoses wsmoses wsmoses left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
forward mode Forward Mode AD mlir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vimarsh6739 @wsmoses