Skip to content

Conversation

dime10
Copy link
Contributor

@dime10 dime10 commented Apr 1, 2025

As discussed here, Enzyme can be compiled with non-LLVM compilers, as long as it is loaded/linked into LLVM tools (clang, opt, ...).

This PR adds a CMake option to suppress the compiler warning introduced in #1883.

@ZuseZ4
Copy link
Collaborator

ZuseZ4 commented Apr 1, 2025

cc @tgymnich, not sure why the Required Integration tests aren't running here, I approved the workflow.

@tgymnich
Copy link
Member

tgymnich commented Apr 1, 2025

@ZuseZ4 I guess this must have been a planned brownout of ubuntu 20.04 runners from GitHub. Here is the fix: #2262. PR is not merged because we still need to decide wether we want to keep C/C++ CI as required or only run C/C++ CI when a relevant file changes (see paths in PR). Both do not work together since the Required CI pass may never run if you don't touch any of the files define in the workflow.

Feel free to merge the PR without the paths: part.

@ZuseZ4 ZuseZ4 enabled auto-merge April 7, 2025 02:43
@ZuseZ4 ZuseZ4 added this pull request to the merge queue Apr 7, 2025
@ZuseZ4
Copy link
Collaborator

ZuseZ4 commented Apr 7, 2025

@tgymnich I removed the path but CI there was blocked too, so I'm unable to merge it, sorry.
However it seems like the 20.04 runners here came back at some point.
So to not have this PR blocked too long and since no one seems to object I've added it to the merge queue, so they don't have to deal with extra warnings.

Merged via the queue into EnzymeAD:main with commit 9238045 Apr 7, 2025
18 of 20 checks passed
gbaraldi pushed a commit to gbaraldi/Enzyme that referenced this pull request Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants