Skip to content

RT1002-22 add bq25188 support #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: emcraft-v3.7.99-ncs1-branch
Choose a base branch
from
Open

RT1002-22 add bq25188 support #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion drivers/charger/charger_bq25180.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@
#define BQ25180_WATCHDOG_DISABLE 0x03
#define BQ25180_DEVICE_ID_MSK GENMASK(3, 0)
#define BQ25180_DEVICE_ID 0x00
#define BQ25188_DEVICE_ID 0x04
#define BQ25180_SHIP_RST_EN_RST_SHIP_MSK GENMASK(6, 5)

Check notice on line 49 in drivers/charger/charger_bq25180.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

You may want to run clang-format on this change 

drivers/charger/charger_bq25180.c:49 
-#define BQ25188_DEVICE_ID 0x04
+#define BQ25188_DEVICE_ID                       0x04
#define BQ25180_SHIP_RST_EN_RST_SHIP_ADAPTER 0x20
#define BQ25180_SHIP_RST_EN_RST_SHIP_BUTTON 0x40

Expand Down Expand Up @@ -205,6 +206,7 @@
if (ret < 0) {
return ret;
}
val &= BQ25180_VBAT_MSK;

*const_charge_voltage_uv = bq25180_vbatreg_to_mv(val) * 1000;

Expand Down Expand Up @@ -324,7 +326,7 @@
}

val &= BQ25180_DEVICE_ID_MSK;
if (val != BQ25180_DEVICE_ID) {
if ((val != BQ25180_DEVICE_ID) && (val != BQ25188_DEVICE_ID)) {
LOG_ERR("Invalid device id: %02x", val);
return -EINVAL;
}
Expand Down
Loading