Skip to content

tests: update PHPUnit version #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tests: update PHPUnit version #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,3 @@ php:
- 7.3
- 7.2
- 7.1
- 7.0
- 5.6
- 5.5
- 5.4
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ $converter->parseString('<h1 id="md">Heading</h1>');
How to Install
--------

This library package requires `PHP 5.4` or later.<br>
This library package requires `PHP 7.1` or later.<br>
Install [Composer](http://getcomposer.org/doc/01-basic-usage.md#installation) and run the following command to get the latest version:

```sh
Expand Down
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@
}
],
"require": {
"php": ">=5.4.0"
"php": ">=7.1"
},
"require-dev": {
"phpunit/phpunit": "^4.8"
"phpunit/phpunit": "^9.5"
},
"autoload": {
"psr-4": {
Expand Down
2 changes: 1 addition & 1 deletion test/ConverterExtraTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class ConverterExtraTest extends ConverterTestCase

/* UTILS
*************************************************************************/
public function setUp()
public function setUp(): void
{
$this->converter = new ConverterExtra;
}
Expand Down
2 changes: 1 addition & 1 deletion test/ConverterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class ConverterTest extends ConverterTestCase

/* UTILS
*************************************************************************/
public function setUp()
public function setUp(): void
{
$this->converter = new Converter;
}
Expand Down
10 changes: 7 additions & 3 deletions test/ConverterTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,19 @@
namespace Test\Markdownify;

use Markdownify\Converter;
use PHPUnit\Framework\TestCase;

require_once(__DIR__ . '/../vendor/autoload.php');

class ConverterTestCase extends \PHPUnit_Framework_TestCase
class ConverterTestCase extends TestCase
{


/* ATTRIBUTES
*************************************************************************/
/**
* @var Converter
*/
protected $converter;


Expand Down Expand Up @@ -554,10 +558,10 @@ public function testResetState()
$converter = new Converter();
$bqOutput = $converter->parseString($blockquote);

$this->assertContains('>', $bqOutput);
$this->assertStringContainsString('>', $bqOutput);

$lbOutput = $converter->parseString($linebreaks);

$this->assertNotContains('>', $lbOutput);
$this->assertStringNotContainsString('>', $lbOutput);
}
}