Skip to content

Conversation

@JosephGoulden
Copy link
Contributor

@JosephGoulden JosephGoulden commented Jul 1, 2025

Updated nixpkgs to 25.05
Replaced cln package postgresql dependency with much smaller libpq.
Utilise new inputs.self.submodules feature to simplify flake use.

Fixes #8328 and #8320

  • The changelog has been updated in the relevant commit(s) according to the guidelines.
  • Tests have been added or modified to reflect the changes.
  • Documentation has been reviewed and updated as needed.
  • Related issues have been listed and linked, including any that this PR closes.

@JosephGoulden JosephGoulden force-pushed the flake-update branch 2 times, most recently from 96bbcaf to 93a1aeb Compare July 1, 2025 14:09
@JosephGoulden
Copy link
Contributor Author

@vincenzopalazzo would you be able to review please?

@niftynei
Copy link
Collaborator

niftynei commented Aug 13, 2025

Tried running this on a macos nix install, got the following errors (nix (Nix) 2.28.4)

15:54~ ⛓️ 🔓nix run "git+https://github.com/hashrelay/lightning?ref=flake#lightningd"
error:
       … while evaluating the attribute 'value'
         at /nix/store/fkjds639pw6ykj3zib7cp4y9i9h6ka9w-source/modules.nix:821:9:
          820|     in warnDeprecation opt //
          821|       { value = addErrorContext "while evaluating the option `${showOption loc}':" value;
             |         ^
          822|         inherit (res.defsFinal') highestPrio;

       … while evaluating the option `flake.apps.aarch64-darwin.lightningd.program':

       … while evaluating the attribute 'mergedValue'
         at /nix/store/fkjds639pw6ykj3zib7cp4y9i9h6ka9w-source/modules.nix:856:5:
          855|     # Type-check the remaining definitions, and merge them. Or throw if no definitions.
          856|     mergedValue =
             |     ^
          857|       if isDefined then

       … while evaluating definitions from `/nix/store/vmxpp69qfl29zis707vl6pi97b6x6wg6-source/modules/transposition.nix':

       … while evaluating the option `perSystem.aarch64-darwin.apps.lightningd.program':

       … while evaluating definitions from `/nix/store/zkabj7rlyjqr7r5vw2fh5fjcfy9hg9bs-source/flake.nix, via option perSystem':

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: undefined variable 'cctools'
       at /nix/store/zkabj7rlyjqr7r5vw2fh5fjcfy9hg9bs-source/nix/pkgs/default.nix:46:7:
           45|     ++ lib.optionals stdenv.isDarwin [
           46|       cctools
             |       ^
           47|       darwin.autoSignDarwinBinariesHook

@JosephGoulden
Copy link
Contributor Author

Thanks for testing it out @niftynei. As a sanity check please could you try nix build nixpkgs#clightning ?

@JosephGoulden JosephGoulden force-pushed the flake-update branch 2 times, most recently from 044636c to 0d8035b Compare August 28, 2025 10:30
@JosephGoulden
Copy link
Contributor Author

@niftynei The branch is flake-update not flake

nix run "git+https://github.com/hashrelay/lightning?ref=flake-update#lightningd"

@JosephGoulden JosephGoulden force-pushed the flake-update branch 3 times, most recently from 848dad0 to 2edfd7b Compare October 31, 2025 12:37
Switched to nixpkgs-unstable
Replaced postgresql dependency with much smaller libpq.
Utilise new inputs.self.submodules feature to simplify flake use
Moved apps to a separate file
Changelog-None
@JosephGoulden
Copy link
Contributor Author

Please could I get a review of this? Not sure who to ask. @ShahanaFarooqui any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants