fix: add crossorigin attribute to style tag #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zangab
force-pushed
the
bugfix/crossorigin-attribute
branch
from
c3de697 to
ad3c82c
Compare
|
The PR was updated to also change the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📖
This pull request adds the
crossoriginattribute to styles injected via thevite_javascript_tag.Background 📜
Vite adds the
crossoriginto styles tags by default, see code in Vite.The Fix 🔨
Vite adds a default
crossOrigin = ''attribute to stylesheets. Therefore, this gem should also add thecrossoriginto thestylesheet_link_tagoptions. In addition, the default value of"anonymous"changes to""which has the identical meaning according to MDN Docs so the default value is the same as in Vite.Fixes #528
Screenshots 📷