- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 432
feat(firmware): add ability to set source for backlight / brightness and volume controls #6684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| @elecpower When you have some time could you look at the companion side please. It needs to be updated to limit the backlight control to only select Pots, Sliders or Switches, | 
| I think this does go against the whole logic, where things are done throuht SF. Now it is a settings, a GF, a SF, for people to understand what happens , it becomes a nightware. What happens if you usually don't need to use the pot, but this new model needs it for a gyro gain for example ? | 
| Looks like #2256 won't be needed anymore then, and the issues it addressed can be moved to here... | 
| 
 No, it gives a mechanism to it without using GF or SF. If you need something more advanced, you use that instead. 
 Same could be said for Brightness GF... i.e. you wouldn't configure it globally, or you use it for both. | 
| The commit above fixes the source list. The dynamic update part is a wip | 
| This PR #6684 is interesting and could be helpful to band-aid the primary problems in SF backlight I observe since introduced in EdgeTX ~v2.6.x. But this PR still does not provide a complete solution to allow setting both an alternate backlight brightness and control... Please consider/investigate issue #5851 as well. Thank you & Happy to test :-) | 
| As I poke with this a bit I find myself agreed with @3djc. We are not talking about a menu navigation button, this is normal user controls and they should be left for user to configure in SF / GF. | 
| 
 Thanks for that. A couple of things: 
 | 
6678ca2    to
    d77e84e      
    Compare
  
    | 
 Noted and will incorporate | 
| Custom function switches not listed correctly and will be addressed as part of the larger issue | 
874fede    to
    a646cea      
    Compare
  
    | TODO: add flex switches to list | 
| @philmoz back to you for testing | 
| 
 Looks good - thank you. | 
ccb7bd7    to
    be52513      
    Compare
  
    | For consistency then, shouldn't the same apply to audio and variometer volumes ? | 
| 
 One step at a time. | 
b527393    to
    d77d486      
    Compare
  
    | Added audio volume control as well. | 
| Looks like I need to rename the source item model to a generic name. I'm open to suggestions. | 
| 
 ControlSourceItemModel | 
d8f5b83    to
    c0e5e5e      
    Compare
  
    
Set a Pot, Slider or Switch to control brightness without using a special / global function.
If a Backlight special / global is defined it will take precedence over this new radio setting.
TODO: