Skip to content

Conversation

@philmoz
Copy link
Collaborator

@philmoz philmoz commented Oct 18, 2025

Set a Pot, Slider or Switch to control brightness without using a special / global function.

If a Backlight special / global is defined it will take precedence over this new radio setting.

TODO:

  • limit selection to Pots, Sliders or Switches Companion radio settings editor.
screenshot_gx12_25-10-18_18-26-08 screenshot_tx16s_25-10-18_18-25-38

@philmoz philmoz added this to the 3.0 milestone Oct 18, 2025
@philmoz philmoz added color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour B&W Related generally to black and white LCD radios labels Oct 18, 2025
@philmoz
Copy link
Collaborator Author

philmoz commented Oct 18, 2025

@elecpower When you have some time could you look at the companion side please.
I have implemented the YAML read/write and added the control to the radio settings edit page.

It needs to be updated to limit the backlight control to only select Pots, Sliders or Switches,

@3djc
Copy link
Collaborator

3djc commented Oct 18, 2025

I think this does go against the whole logic, where things are done throuht SF. Now it is a settings, a GF, a SF, for people to understand what happens , it becomes a nightware.

What happens if you usually don't need to use the pot, but this new model needs it for a gyro gain for example ?

@pfeerick
Copy link
Member

Looks like #2256 won't be needed anymore then, and the issues it addressed can be moved to here...

@pfeerick
Copy link
Member

I think this does go against the whole logic, where things are done throuht SF. Now it is a settings, a GF, a SF, for people to understand what happens , it becomes a nightware.

No, it gives a mechanism to it without using GF or SF. If you need something more advanced, you use that instead.

What happens if you usually don't need to use the pot, but this new model needs it for a gyro gain for example?

Same could be said for Brightness GF... i.e. you wouldn't configure it globally, or you use it for both.

@elecpower
Copy link
Collaborator

The commit above fixes the source list. The dynamic update part is a wip

@pitts-mo
Copy link

pitts-mo commented Oct 18, 2025

This PR #6684 is interesting and could be helpful to band-aid the primary problems in SF backlight I observe since introduced in EdgeTX ~v2.6.x. But this PR still does not provide a complete solution to allow setting both an alternate backlight brightness and control... Please consider/investigate issue #5851 as well.

Thank you & Happy to test :-)

@pitts-mo
Copy link

As I poke with this a bit I find myself agreed with @3djc. We are not talking about a menu navigation button, this is normal user controls and they should be left for user to configure in SF / GF.

@philmoz
Copy link
Collaborator Author

philmoz commented Oct 18, 2025

The commit above fixes the source list. The dynamic update part is a wip

Thanks for that. A couple of things:

  • Tilt X & Tilt Y should not be selectable
  • Negative / inverted values should be selectable.

@philmoz philmoz force-pushed the philmoz/backlight-source branch from 6678ca2 to d77e84e Compare October 18, 2025 19:58
@elecpower
Copy link
Collaborator

  • Tilt X & Tilt Y should not be selectable
  • Negative / inverted values should be selectable.

Noted and will incorporate

@elecpower
Copy link
Collaborator

Custom function switches not listed correctly and will be addressed as part of the larger issue

@philmoz philmoz force-pushed the philmoz/backlight-source branch from 874fede to a646cea Compare October 19, 2025 03:34
@elecpower
Copy link
Collaborator

elecpower commented Oct 19, 2025

TODO: add flex switches to list
Update: done

@elecpower
Copy link
Collaborator

@philmoz back to you for testing

@philmoz
Copy link
Collaborator Author

philmoz commented Oct 19, 2025

@philmoz back to you for testing

Looks good - thank you.

@philmoz philmoz force-pushed the philmoz/backlight-source branch from ccb7bd7 to be52513 Compare October 20, 2025 05:46
@pfeerick pfeerick changed the title feat(firmware): add ability to set source for backlight / brightness control. feat(firmware): add ability to set source for backlight / brightness control Oct 26, 2025
@3djc
Copy link
Collaborator

3djc commented Oct 26, 2025

For consistency then, shouldn't the same apply to audio and variometer volumes ?

@philmoz
Copy link
Collaborator Author

philmoz commented Oct 26, 2025

For consistency then, shouldn't the same apply to audio and variometer volumes ?

One step at a time.

@philmoz philmoz force-pushed the philmoz/backlight-source branch 2 times, most recently from b527393 to d77d486 Compare October 30, 2025 00:17
@philmoz philmoz changed the title feat(firmware): add ability to set source for backlight / brightness control feat(firmware): add ability to set source for backlight / brightness and volume controls Oct 30, 2025
@philmoz
Copy link
Collaborator Author

philmoz commented Oct 30, 2025

Added audio volume control as well.

@elecpower
Copy link
Collaborator

Looks like I need to rename the source item model to a generic name. I'm open to suggestions.

@philmoz
Copy link
Collaborator Author

philmoz commented Oct 30, 2025

Looks like I need to rename the source item model to a generic name. I'm open to suggestions.

ControlSourceItemModel

@philmoz philmoz force-pushed the philmoz/backlight-source branch from d8f5b83 to c0e5e5e Compare October 30, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B&W Related generally to black and white LCD radios color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants