Skip to content

Conversation

@philmoz
Copy link
Collaborator

@philmoz philmoz commented Oct 16, 2025

Changes:

  • Don't call object functions when object is not visible to improve performance.
  • Allow 'filled' property of rectangles to be a function.
  • Page 'title' and 'subtitle' properties can be functions.

@philmoz philmoz added this to the 2.11.4 milestone Oct 16, 2025
@philmoz philmoz added color Related generally to color LCD radios lua-api Lua API related labels Oct 16, 2025
@philmoz philmoz marked this pull request as draft October 16, 2025 22:12
@pfeerick pfeerick changed the title chore(lua,lvgl): improvements for Lua LVGL API. chore(lua,lvgl): improvements for Lua LVGL API Oct 18, 2025
@philmoz philmoz force-pushed the philmoz/lua-lvgl branch 4 times, most recently from 5517469 to b0c8c0f Compare October 23, 2025 07:33
@pfeerick
Copy link
Member

pfeerick commented Oct 26, 2025

Is this actually ready to be reviewed/merged? I've been ignoring it as it is still marked as "Draft" ;)

@philmoz
Copy link
Collaborator Author

philmoz commented Oct 26, 2025

Is this actually ready to be reviewed/merged? I've been ignoring it as it is still marked as "Draft" ;)

I have other related things I was working on for this PR; but keep getting sidetracked finding small bugs and issues with new radios in the pipeline.

@philmoz philmoz marked this pull request as ready for review October 26, 2025 22:38
@pfeerick
Copy link
Member

Was just checking I wasn't adding to the workload by not merging something you were actually done with. Let's run with this as it is then, as the LVGL API is going to continue to evolve and improve anyway over time.

@pfeerick pfeerick changed the title chore(lua,lvgl): improvements for Lua LVGL API chore(color): improvements for Lua LVGL API Oct 26, 2025
@pfeerick pfeerick merged commit f72fcc3 into main Oct 26, 2025
47 checks passed
@pfeerick pfeerick deleted the philmoz/lua-lvgl branch October 26, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

color Related generally to color LCD radios lua-api Lua API related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants