implement k-mediods algorithm and tests #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement kMediods algorithm Run tests with the following: python -m unittest -v test.test_k_medoids
Ecohen4
reviewed
May 8, 2019
There was a problem hiding this comment.
Overall, very nice. Just a few comments:
- Written in Python 2, which has been superseded by Python 3 for years.
- Only two commit messages -- I would have expected a commit-as-you-go approach. Atomic commits also provides insight to the reviewer on your approach and order of operations.
- Test are green, which is always good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement kMediods algorithm with these assumptions:
Run tests with the following:
python -m unittest -v test.test_k_mediods