Make fields implement FieldTraitAwareInterface instead of FieldInterface #7011
Conversation
| */ | ||
| public function setDefaultColumns(int|string $cols): self; | ||
|
|
||
| public function setIcon(?string $iconCssClass, string $invokingMethod = 'FormField::setIcon()'): self; |
There was a problem hiding this comment.
This method is only implemented by FormField, and is not part of FieldTrait
There was a problem hiding this comment.
Removing a method from an interface is a BC break and should only be done in major version
What you can do instead is providing a blank deprecated method setIcon in the trait
There was a problem hiding this comment.
@VincentLanglet : alright, it's restored. However I do not really agree with your point :
Firstly, FieldTraitAwareInterface is not used anywhere in the codebase, and I doubt anybody uses it yet, since none of the existing EasyAdmin fields implements it. (That's the goal of this PR).
Secondly, the signature in this interface does not match the only implementation of it in FormField, so I had to change the signature in FormField.
Thirdly, the goal of this interface is to have a common contract implemented by ALL the fields implementing FieldTrait. I don't see the point of adding it for a single field (FormField.)
Short description of what this feature will allow to do:
The
FieldTraitAwareInterfacewas added to the repository to serve as the interface for fields that useFieldTrait. However, none of the fields that actually useFieldTraitimplement this interface—they only implementFieldInterface. This makesFieldTraitAwareInterfaceeffectively unused and defeats its intended purpose.Example of how to use this feature
This change would enable us to create field factories that return
FieldTraitAwareInterfaceinstances, which could then be manipulated using the methods provided byFieldTrait. We have found this approach particularly valuable for defining fields outside of CRUD controllers, allowing them to be reused across different components.Closes #7010