Deprecate ActionConfigDto::getActions
#6999
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
statelessActions
branch
from
65bc164 to
16e13c4
Compare
Merged
VincentLanglet
force-pushed
the
statelessActions
branch
from
16e13c4 to
965149e
Compare
|
Do you mind taking a look @javiereguiluz ? This is needed for #7026 Thanks |
Seb33300
reviewed
Sep 20, 2025
| /** | ||
| * @return array<string,array<string,ActionDto>> | ||
| */ | ||
| public function getActionList(): array |
There was a problem hiding this comment.
getAllActions() instead of getActionList()?
Suggested change
| public function getActionList(): array | |
| public function getAllActions(): array |
There was a problem hiding this comment.
Sure, indeed not a bad idea.
I'm waiting for an opinion from javiereguiluz on this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some errors reported by PHPStan level 7 is related to the fact that
might be non-ok if getActions return an array, since the return type is
The issue is this method does two things
A solution could be to split the method in two:
getPageActionsandgetActionList(naming is challengeable).Also
getPageActionscan take thepageNameas args rather than relying on a private property since the page is accessible with(and you might want to know the actions of another page)
Then I deprecated
setPageName(but I cannot trigger a deprecation since it has to be used in easyAdmin code for BC)This PR should solve issue like #6531 or at least helps for debug.