[BUG]: Fix bug with update command #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asreimer
requested review from
ljlamarche and
pmreyes2
and removed request for
ljlamarche
pmreyes2
requested changes
Nov 12, 2020
pmreyes2
approved these changes
Nov 12, 2020
|
@pmreyes2 also tested the code and reported that it works as expected. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #73 and adds documentation about the
updatecommand. I've also bumped the release version numbers in preparation of a quick minor release.TESTING
To test this, in the same resen session:
Without this PR, you'll see that you can't access the latest 2020.2.0 resen-core without restarting resen in between steps 1 and 2.
DOCS
You can view the update to the docs here: https://resen.readthedocs.io/en/bugfix_update/usage.html#update-list-of-available-cores