PacketSniffer improvements #1413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case init() ever gets called a second time (depends on framework). Signed-off-by: Moritz Barsnick <[email protected]>
This aids in debugging and finding the PCAP trace file. Signed-off-by: Moritz Barsnick <[email protected]>
Actually process the error buffer handed to pcap_open_live(). Initialize it and evaluate the length. This allows for useful log messages such as: void module::PacketSniffer::init() :: Could not open device "enp0s3", sniffing disabled. Error: enp0s3: You don't have permission to capture on that device (socket: Operation not permitted) Signed-off-by: Moritz Barsnick <[email protected]>
This does not provide Ethernet headers, but works just as well. Signed-off-by: Moritz Barsnick <[email protected]>
Signed-off-by: Moritz Barsnick <[email protected]>
Signed-off-by: Moritz Barsnick <[email protected]>
barsnick
requested review from
SebaLukas,
corneliusclaussen and
hikinggrass
as code owners
SebaLukas
reviewed
Oct 13, 2025
SebaLukas
reviewed
Oct 13, 2025
SebaLukas
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Some improvements to PacketSniffer logging and error handling.
Issue ticket number and link
Checklist before requesting a review