Adding set_powersupply_capabilities cmd to ISO15118_charger interface #1390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebaLukas
requested review from
Pietfried,
a-w50,
andistorm,
corneliusclaussen,
hikinggrass,
james-ctc and
mlitre
as code owners
|
Before merging this PR, EVerest/libiso15118#156 should be merged as well |
…. Now the min and max limits of the powersupply can be sent in the ChargeParameterDiscoveryRes messages Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
SebaLukas
force-pushed
the
feat/using-powersupply-limits-in-charge_parameter_discovery
branch
from
627b4a1 to
b539c4d
Compare
Pietfried
reviewed
Oct 14, 2025
| The supported grid code detection method supported by the EVSE | ||
| type: string | ||
| $ref: /iso15118#/GridCodeIslandingDetectionMethod | ||
| Capabilities: |
There was a problem hiding this comment.
Is there a reason why this existing type is not reused? https://github.com/EVerest/everest-core/blob/main/types/power_supply_DC.yaml#L36
| BeforeCableCheck, | ||
| }; | ||
|
|
||
| struct PowerCapabilities { |
There was a problem hiding this comment.
nit: PowerSupplyCapabilities
Comment on lines
+254
to
+266
| types::iso15118::Capabilities capabilities; | ||
| capabilities.max_charge_current = caps.max_export_current_A; | ||
| capabilities.min_charge_current = caps.min_export_current_A; | ||
| capabilities.max_charge_power = caps.max_export_power_W; | ||
| capabilities.min_charge_power = caps.min_export_current_A * caps.min_export_voltage_V; | ||
| capabilities.max_voltage = caps.max_export_voltage_V; | ||
| capabilities.min_voltage = caps.min_export_voltage_V; | ||
| capabilities.max_discharge_current = caps.max_import_current_A; | ||
| capabilities.min_discharge_current = caps.min_import_current_A; | ||
| capabilities.max_discharge_power = caps.max_import_power_W; | ||
| capabilities.min_discharge_power = | ||
| (caps.min_import_voltage_V.has_value() and caps.min_import_current_A.has_value()) | ||
| ? std::make_optional(caps.min_import_voltage_V.value() * caps.min_import_current_A.value()) |
There was a problem hiding this comment.
Could mostly be omited if types::power_supply_DC::Capabilities is used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Now the min and max limits of the powersupply can be sent in the ChargeParameterDiscoveryRes messages
Issue ticket number and link
The power supply limits should be sent to the EV in the DcChargeParameterDiscoveryRes and not the actual limits from the EnergyManager.
Checklist before requesting a review