chore(everest-ci): bump build-kit base image version to debian13 #1381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Heinrich <[email protected]>
andistorm
requested review from
Pietfried and
corneliusclaussen
as code owners
Signed-off-by: Andreas Heinrich <[email protected]>
Signed-off-by: Andreas Heinrich <[email protected]>
Signed-off-by: Andreas Heinrich <[email protected]>
andistorm
changed the title
james-ctc
reviewed
Sep 29, 2025
|
|
||
| TEST(openssl, base64Decode) { | ||
| auto res = openssl::base64_decode(&iso_exi_a_hash_b64[0], sizeof(iso_exi_a_hash_b64)); | ||
| auto res = openssl::base64_decode(iso_exi_a_hash_b64, std::strlen(iso_exi_a_hash_b64)); |
There was a problem hiding this comment.
This change needs to be reverted.
openssl::base64_decode() takes a constant pointer and a length - normally from a buffer of known size. It does not need to be null terminated.
And it if isn't null terminated then strlen() will not help.
james-ctc
reviewed
Sep 29, 2025
| ASSERT_EQ(res.size(), sizeof(iso_exi_a_hash)); | ||
| EXPECT_EQ(std::memcmp(res.data(), &iso_exi_a_hash[0], res.size()), 0); | ||
| res = openssl::base64_decode(&iso_exi_sig_b64[0], sizeof(iso_exi_sig_b64)); | ||
| res = openssl::base64_decode(iso_exi_sig_b64, std::strlen(iso_exi_sig_b64)); |
There was a problem hiding this comment.
This change needs to be reverted.
openssl::base64_decode() takes a constant pointer and a length - normally from a buffer of known size. It does not need to be null terminated.
And it if isn't null terminated then strlen() will not help.
james-ctc
reviewed
Sep 29, 2025
| std::size_t buffer_len = buffer.size(); | ||
|
|
||
| EXPECT_TRUE(openssl::base64_decode(&iso_exi_a_hash_b64[0], sizeof(iso_exi_a_hash_b64), buffer.data(), buffer_len)); | ||
| EXPECT_TRUE(openssl::base64_decode(iso_exi_a_hash_b64, std::strlen(iso_exi_a_hash_b64), buffer.data(), buffer_len)); |
There was a problem hiding this comment.
see above why strlen isn't a solution
james-ctc
reviewed
Sep 29, 2025
|
|
||
| TEST(openssl, base64DecodeNl) { | ||
| auto res = openssl::base64_decode(&iso_exi_a_hash_b64_nl[0], sizeof(iso_exi_a_hash_b64_nl)); | ||
| auto res = openssl::base64_decode(iso_exi_a_hash_b64_nl, std::strlen(iso_exi_a_hash_b64_nl)); |
There was a problem hiding this comment.
see above why strlen isn't a solution
james-ctc
reviewed
Sep 29, 2025
| ASSERT_EQ(res.size(), sizeof(iso_exi_a_hash)); | ||
| EXPECT_EQ(std::memcmp(res.data(), &iso_exi_a_hash[0], res.size()), 0); | ||
| res = openssl::base64_decode(&iso_exi_sig_b64_nl[0], sizeof(iso_exi_sig_b64_nl)); | ||
| res = openssl::base64_decode(iso_exi_sig_b64_nl, std::strlen(iso_exi_sig_b64_nl)); |
There was a problem hiding this comment.
see above why strlen isn't a solution
james-ctc
reviewed
Sep 29, 2025
|
|
||
| EXPECT_TRUE( | ||
| openssl::base64_decode(&iso_exi_a_hash_b64_nl[0], sizeof(iso_exi_a_hash_b64_nl), buffer.data(), buffer_len)); | ||
| openssl::base64_decode(iso_exi_a_hash_b64_nl, std::strlen(iso_exi_a_hash_b64_nl), buffer.data(), buffer_len)); |
There was a problem hiding this comment.
see above why strlen isn't a solution
james-ctc
requested changes
Sep 29, 2025
Signed-off-by: Andreas Heinrich <[email protected]>
Signed-off-by: Andreas Heinrich <[email protected]>
Signed-off-by: Andreas Heinrich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review