Skip to content

feat: SerialCommHub add read & write coils commands #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: SerialCommHub add read & write coils commands #1362

wants to merge 3 commits into from
+129 −5

Conversation

markxoe
Copy link
Contributor

@markxoe markxoe commented Sep 11, 2025

Describe your changes

  • adds modbus_read_coils and modbus_write_single_coil to the serial_communication_hub interface
  • adds ResultBool to serial_comm_hub_requests types for boolean coils data
  • adds implementations for added commands in SerialCommHub module
  • fixes WriteSingleCoil request in tiny_modbus_rtu library

New commands have been manually tested against a pymodbus server

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pietfried Pietfried Awaiting requested review from Pietfried Pietfried is a code owner

@hikinggrass hikinggrass Awaiting requested review from hikinggrass hikinggrass is a code owner

@corneliusclaussen corneliusclaussen Awaiting requested review from corneliusclaussen corneliusclaussen is a code owner

@SebaLukas SebaLukas Awaiting requested review from SebaLukas SebaLukas is a code owner

@andistorm andistorm Awaiting requested review from andistorm andistorm is a code owner

@mlitre mlitre Awaiting requested review from mlitre mlitre is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@markxoe