RpcApi: add new JSON RPC API module #1324
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barsnick
force-pushed
the
feature/json-rpc-api
branch
8 times, most recently
from
acd8932 to
9dc9ae4
Compare
barsnick
requested review from
AssemblyJohn,
MarzellT,
Pietfried,
SebaLukas,
andistorm,
corneliusclaussen,
hikinggrass and
mlitre
as code owners
hikinggrass
requested changes
Aug 29, 2025
barsnick
commented
Sep 5, 2025
Fixed. |
hikinggrass
requested changes
Sep 5, 2025
modules/API/RpcApi/tools/python-client-gui/everest-json-rpc-websocket-client.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Fabian Hartung <[email protected]> Signed-off-by: Moritz Barsnick <[email protected]> Co-authored-by: Fabian Hartung <[email protected]> Co-authored-by: Moritz Barsnick <[email protected]>
Signed-off-by: Fabian Hartung <[email protected]>
Signed-off-by: Moritz Barsnick <[email protected]>
Signed-off-by: Moritz Barsnick <[email protected]>
Signed-off-by: Fabian Hartung <[email protected]>
…tocol_to_charge_protocol function Signed-off-by: Fabian Hartung <[email protected]>
Signed-off-by: Fabian Hartung <[email protected]>
Signed-off-by: Fabian Hartung <[email protected]>
Signed-off-by: Moritz Barsnick <[email protected]>
Signed-off-by: Moritz Barsnick <[email protected]>
Signed-off-by: Moritz Barsnick <[email protected]>
As changed in the merged PR #1319. Signed-off-by: Moritz Barsnick <[email protected]>
Signed-off-by: Fabian Hartung <[email protected]>
Signed-off-by: Fabian Hartung <[email protected]>
Add a Findjson-rpc-cxx.cmake for non-EDM builds. The target_include_directories() directive needs to be different for EDM and non-EDM (Yocto) builds for the header-only json-rpc-cxx. Also remove json-rpc-cxx from target_link_libraries(), as it is header-only. Signed-off-by: Moritz Barsnick <[email protected]>
…figuration from YAML files Signed-off-by: Fabian Hartung <[email protected]>
Signed-off-by: Moritz Barsnick <[email protected]>
Signed-off-by: Fabian Hartung <[email protected]>
Signed-off-by: Moritz Barsnick <[email protected]>
Introduce a little bit more consistency. Signed-off-by: Moritz Barsnick <[email protected]>
Signed-off-by: Moritz Barsnick <[email protected]>
Only listen on all interfaces if explicitly asked via config "all". Do not accept an empty string. Signed-off-by: Moritz Barsnick <[email protected]>
Signed-off-by: Moritz Barsnick <[email protected]>
Signed-off-by: Moritz Barsnick <[email protected]>
… flag EVSE index 0 is reserved for the charger itself and should not be used to set/clear the EVSE error present flag. In the future, we might want to introduce a charger error present flag. Signed-off-by: Fabian Hartung <[email protected]>
… storage Signed-off-by: Fabian Hartung <[email protected]>
… on session start Signed-off-by: Fabian Hartung <[email protected]>
Signed-off-by: Fabian Hartung <[email protected]>
Signed-off-by: Fabian Hartung <[email protected]>
In case charging is already paused, it is not necessary to set the current limit to 0. The current limit is only set to 0 if it is necessary to prevent charging. Signed-off-by: Fabian Hartung <[email protected]>
…nd charging is not allowed Signed-off-by: Fabian Hartung <[email protected]>
Added a wait_for_current_limit_applied method to the EVSEStatusStore to allow waiting for the requested current limit to be applied with a timeout. This allows correct error reporting if the limit could not be applied in time. The timeout is set to 5 seconds in the RpcApiRequestHandler.cpp. Signed-off-by: Fabian Hartung <[email protected]>
…_current case Signed-off-by: Fabian Hartung <[email protected]>
barsnick
force-pushed
the
feature/json-rpc-api
branch
from
6ac26d4 to
f6d5ae4
Compare
…ts when applying phase count Signed-off-by: Fabian Hartung <[email protected]>
barsnick
added a commit
to EVerest/meta-everest
that referenced
this pull request
Oct 1, 2025
This library is required for the RpcApi module from everest-core PR EVerest/everest-core#1324. Also provide a minimal json-rpc-cxxConfig.cmake with INTERFACE target for the header-only library. This allows CMake to resolve and include the json-rpc-cxx target using find_package(json-rpc-cxx REQUIRED). Signed-off-by: Fabian Hartung <[email protected]> Signed-off-by: Moritz Barsnick <[email protected]> Co-authored-by: Fabian Hartung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This introduces a new API module RpcApi, which uses JSON RPC, and WebSockets as a transport layer.
It uses both RPC Methods and Notifications.
This is the implementation according to the proposal with was discussed here on Zulip and documented here. The original proposal what slightly modified, as several details proved inconsistent, impractical, or just mis-specified.
Documentation of the current state of implementation is included in the module's
docs/subdirectory. The current (or the final merged) state will be manifested as API version 1.0.0. Future updates to the external API definition will require version bumps.A Python GUI test client is included under
modules/API/RpcApi/tools/python-client-gui/.Not implemented in the current state of the API:
This will be added later, with corresponding bumps of the API version (where applicable).
A non-squashed version of this work is found in the branch feature/json-rpc-api-nosquash. for reference regarding small change steps, commit messages with motivations, and so on.
Co-authored-by: Fabian Hartung [email protected]
Co-authored-by: Moritz Barsnick [email protected]
Issue ticket number and link
Checklist before requesting a review