-
Notifications
You must be signed in to change notification settings - Fork 165
Add TUV-x to CAM #784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TUV-x to CAM #784
Conversation
Develop 160 tuv build
Develop 162 draft wrapper
* update to latest TUV-x * add heating rate terms to config * add heating rate calcs * remove default output of photo rates * remove default TUV-x output * initialize heating rates to zero * fix max sza type * update TUV-x commit
…dexing (#10) * link to cpp std lib * fix CMake flag, update TUV-x, and fix aerosol wavelength grid use
Are there plans to bring biological effects in to this PR? @coupewx has coupled a version of WACCM4 with TUV (from @cbardeen) to POP in CESM2 to compute UV inhibition in ocean plankton groups; we would like to bring this work into CESM3 (with MOM6 instead of POP), and are trying to scope out what would be involved. If this update to CAM provides fields like UV index and phytoplankton damage per Cullen et al (see this block of code from the version of CAM he is currently using), that would reduce the workload on our end. We skimmed through the changes in this PR and didn't see anything - if we missed something, could you please point us to it? |
@dkinnison should weigh in on this |
@mattldawson |
args += "-DCMAKE_C_COMPILER_WORKS=1 " | ||
args += "-DCMAKE_Fortran_COMPILER_WORKS=1 " | ||
args += "-DCMAKE_CXX_COMPILER_WORKS=1 " | ||
cmd = "cmake {} .".format(args) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattldawson
I believe to get the correct compiler flags you need this line:
args += "-DDEBUG={} ".format(build.get_value("DEBUG"))
@mattldawson - Is this ready for review? If so, then please move it out of draft |
Hi @cacraigucar - not quite yet. we're just merging in the latest commit in cam_development and testing |
This PR contributes to #757 by including TUV-x in the CAM build and introducing a TUV-x wrapper to allow CAM-Chem photolysis rates to be calculated in-line by TUV-x. @stacywalters @tilmes @lkemmons @dkinnison
Using TUV-x for photolysis rate calculations in CAM runs is disabled pending science evaluation/implementation of:
This is my first CAM PR and I have some remaining questions about the correct way to do some things (which I will add as comments on this PR), so I'm leaving it in draft mode for now.