Skip to content

Conversation

mattldawson
Copy link
Collaborator

This PR contributes to #757 by including TUV-x in the CAM build and introducing a TUV-x wrapper to allow CAM-Chem photolysis rates to be calculated in-line by TUV-x. @stacywalters @tilmes @lkemmons @dkinnison

Using TUV-x for photolysis rate calculations in CAM runs is disabled pending science evaluation/implementation of:

  • cross section and quantum yield data sets
  • aerosol optical inputs to TUV-x
  • cloud optical inputs to TUV-x
  • heating rate calculations

This is my first CAM PR and I have some remaining questions about the correct way to do some things (which I will add as comments on this PR), so I'm leaving it in draft mode for now.

mattldawson and others added 30 commits October 6, 2022 10:02
mattldawson and others added 6 commits February 1, 2024 10:13
* update to latest TUV-x

* add heating rate terms to config

* add heating rate calcs

* remove default output of photo rates

* remove default TUV-x output

* initialize heating rates to zero

* fix max sza type

* update TUV-x commit
…dexing (#10)

* link to cpp std lib

* fix CMake flag, update TUV-x, and fix aerosol wavelength grid use
@mnlevy1981
Copy link

Are there plans to bring biological effects in to this PR? @coupewx has coupled a version of WACCM4 with TUV (from @cbardeen) to POP in CESM2 to compute UV inhibition in ocean plankton groups; we would like to bring this work into CESM3 (with MOM6 instead of POP), and are trying to scope out what would be involved. If this update to CAM provides fields like UV index and phytoplankton damage per Cullen et al (see this block of code from the version of CAM he is currently using), that would reduce the workload on our end. We skimmed through the changes in this PR and didn't see anything - if we missed something, could you please point us to it?

@fvitt
Copy link

fvitt commented Jul 3, 2024

Are there plans to bring biological effects in to this PR? @coupewx has coupled a version of WACCM4 with TUV (from @cbardeen) to POP in CESM2 to compute UV inhibition in ocean plankton groups; we would like to bring this work into CESM3 (with MOM6 instead of POP), and are trying to scope out what would be involved. If this update to CAM provides fields like UV index and phytoplankton damage per Cullen et al (see this block of code from the version of CAM he is currently using), that would reduce the workload on our end. We skimmed through the changes in this PR and didn't see anything - if we missed something, could you please point us to it?

@dkinnison should weigh in on this

@fvitt
Copy link

fvitt commented Sep 9, 2024

@mattldawson
Is the version of TUVx used in your branch near the head of NCAR/tuv-x?
Do you have a test case for WACCM including the json file needed for Js and chemical heating?

args += "-DCMAKE_C_COMPILER_WORKS=1 "
args += "-DCMAKE_Fortran_COMPILER_WORKS=1 "
args += "-DCMAKE_CXX_COMPILER_WORKS=1 "
cmd = "cmake {} .".format(args)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattldawson
I believe to get the correct compiler flags you need this line:

       args += "-DDEBUG={} ".format(build.get_value("DEBUG"))

@cacraigucar
Copy link
Collaborator

@mattldawson - Is this ready for review? If so, then please move it out of draft

@mattldawson
Copy link
Collaborator Author

@mattldawson - Is this ready for review? If so, then please move it out of draft

Hi @cacraigucar - not quite yet. we're just merging in the latest commit in cam_development and testing

@mattldawson
Copy link
Collaborator Author

closing so that @fvitt and @jzhan166 can resubmit from a branch on Francis's fork (for after I'm gone)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants