Skip to content

Conversation

jimmielin
Copy link
Member

@jimmielin jimmielin commented Aug 15, 2025

Companion PR: ESCOMP/atmospheric_physics#270

Purpose of changes (include the issue number and title text for each relevant GitHub issue):

Describe any changes made to build system:

  • add holtslag_boville CCPP scheme
  • add vertical_diffusion CCPP scheme

Describe any changes made to the namelist: N/A

List any changes to the defaults for the boundary datasets: N/A

Describe any substantial timing or memory changes: N/A

Code reviewed by:

List all files eliminated:

D       src/physics/cam/hb_diff.F90
  - moved to atmos_phys as CCPPized holstlag_boville scheme
D       src/physics/cam/vdiff_lu_solver.F90
  - moved to atmos_phys into to_be_ccppized (unchanged)

List all files added and what they do: N/A

List all existing files that have been modified, and describe the changes:

R053    src/physics/cam/diffusion_solver.F90    src/physics/cam/diffusion_solver_cam.F90
  - this is the "remnant" diffusion solver supporting WACCM with molecular diffusion.
  - partial refactor to avoid excessive code divergence with CCPPized diffusion_solver.
  - renamed to avoid name conflict with CCPPized diffusion_solver.

M       bld/configure
  - add holtslag_boville and diffusion_solver folders in atmos_phys/schemes to build.

M       src/physics/cam/vertical_diffusion.F90
  - use CCPPized subroutines for HB and vertical diffusion solver.

M       src/physics/cam/eddy_diff_cam.F90
  - use CCPPized vertical diffusion solver.

M       src/physics/cam/molec_diff.F90
  - dechunkize and use assumed dimensions for vd_lu_qdecomp.

M       src/physics/cam/clubb_intr.F90
  - use CCPPized HB boundary layer computation.

M       src/physics/cam/ref_pres.F90
  - comment update.

M       src/physics/cam/rk_stratiform_cam.F90
  - Correctly update AST pbuf field in RK stratiform CAM interface for snapshot consistency (bit-for-bit).

M       src/physics/cam7/physpkg.F90
M       src/physics/cam/physpkg.F90
M       bld/build-namelist
M       bld/namelist_files/namelist_definition.xml
  - move Beljaars, TMS drag call routines to physpkg level for snapshotting.
  - add orographic_form_drag_stress snapshot point.

M       src/control/cam_snapshot_common.F90
  - expand size of cam_in snapshot output maximum because it needs to fit all constituents.

Verified bit-for-bit with Derecho Intel prior to submitting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant