-
Notifications
You must be signed in to change notification settings - Fork 8
add sen2like udp #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add sen2like udp #277
Conversation
|
Sorry for the delay! We have been working on a number of updates for sen2like with telespazio and wanted to finish the updates before publishing the udp. The biggest change, that also affected this PR, is that openEO's sen2like can now also process SENTINEL2_L2A, so I updated the example to start from this collection. Other than that, I would appreciate your reviews! |
jdries
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for submitting the PR!
We normally have a convenient 'preview' feature, allowing to inspect how it looks like in the real catalog, but the github action seems to fail.
So I anyway went ahead for a review, made some suggestions.
algorithm_catalog/eodc/sen2like/benchmark_scenarios/sen2like.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Jeroen Dries <[email protected]>
Is this error related to the udp and is there anything I can try updating in the PR? I was trying to understand what is failing, but since it is in the |
jdries
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, it works!
Given that our auto-preview has an issue with forks, I propose that we merge it already.
This may mean that we need to resolve minor things afterwards, but the basics should be fine as far as I can see.
No description provided.