Add close icon to breakage note tooltip #3034
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostwords
reviewed
Nov 21, 2024
The text goes from 3 lines to 4 lines. I think it looks okay but also might be able to prevent that by making the icon smaller and closer to the corner. 
|
ghostwords
force-pushed
the
persist-breakage-tooltip
branch
3 times, most recently
from
43ae667 to
dc5306a
Compare
ghostwords
force-pushed
the
add-close-button-tooltip
branch
from
5ce9620 to
a36d988
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are making the breakage tooltip appear consistently (#3029), we should follow tooltip best practices and make it clear how users can close it