Drop OUTPUT_PYTHON from 0:UART #427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 1, 2021
Contributor
Author
|
@dreamsource-tai why was this PR closed? I believe this problem still exists on master. |
fornellas
force-pushed
the
drop_OUTPUT_PYTHON
branch
from
94baed5 to
16bafd0
Compare
fornellas
force-pushed
the
drop_OUTPUT_PYTHON
branch
from
16bafd0 to
457b7a4
Compare
Contributor
Author
|
@dreamsource-tai any reason why this PR can't be merged? It's been open for over a year at this point... |
Contributor
Author
|
@dreamsource-tai any reason why this PR can't be merged? It's been open for over a year at this point. It should be either merged or rejected with a reason why. PS: perhaps the solution could be simply to remove both broken UART decoders, see discussion here. |
Owner
|
@fornellas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure the rationale, but we have 2 UART decoders:
0:UARTsays it outputsuart, documents it atOUTPUT_PYTHONbut does NOT output anything.1:UARTsays it outputsuart, documents it atOUTPUT_PYTHONand DOES output it.This PR removes the wrong declaration from
0:UARTso that people cant't attempt to stack decodes for the case where it does not work.PS: I've cut a PR to add upstream uart decoder which does not have the issue above and supports setting RX & TX #429. Perhaps the fix here is simply removing both problematic
0:UARTand1:UART.