Skip to content

Conversation

avivace
Copy link

@avivace avivace commented Feb 9, 2025

@avivace avivace marked this pull request as draft February 9, 2025 16:49
@avivace avivace changed the title Download games as Homebrew Hub Download games as Homebrew Hub entries Feb 10, 2025
avivace and others added 2 commits February 13, 2025 21:26
Co-authored-by: Ryszard Knop <[email protected]>
Co-authored-by: Ryszard Knop <[email protected]>
@DragoonAethis
Copy link
Owner

FYI: The main branch is now running on uv, so Poetry will complain about its metadata missing if you rebase your changes locally on main. Other than that your changes merge in cleanly.

@avivace
Copy link
Author

avivace commented Feb 25, 2025

FYI: The main branch is now running on uv, so Poetry will complain about its metadata missing if you rebase your changes locally on main. Other than that your changes merge in cleanly.

Thanks for the heads up, I'll rebase and see if uv works on my branch then

@DragoonAethis
Copy link
Owner

LGTM now - if it's ready for your use cases, mark it as ready for review, I'll merge and do a new release after that.

@avivace
Copy link
Author

avivace commented Mar 23, 2025

Thanks, I'm still missing some logic changing how the folders/files are saved, I'll ping you for another review when I have it

@avivace avivace marked this pull request as ready for review June 1, 2025 20:18
@avivace
Copy link
Author

avivace commented Jun 1, 2025

@DragoonAethis would you mind taking a preliminar look now? It technically works and I started using it to import a lot of stuff on Homebrew Hub, but the logic I added is pretty much all over the place. If you have some ideas on how to make this more modular/maintainable I'd be happy to follow up on your suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants