-
-
Notifications
You must be signed in to change notification settings - Fork 17
Download games as Homebrew Hub entries #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Ryszard Knop <[email protected]>
Co-authored-by: Ryszard Knop <[email protected]>
FYI: The main branch is now running on uv, so Poetry will complain about its metadata missing if you rebase your changes locally on main. Other than that your changes merge in cleanly. |
Thanks for the heads up, I'll rebase and see if uv works on my branch then |
LGTM now - if it's ready for your use cases, mark it as ready for review, I'll merge and do a new release after that. |
Thanks, I'm still missing some logic changing how the folders/files are saved, I'll ping you for another review when I have it |
@DragoonAethis would you mind taking a preliminar look now? It technically works and I started using it to import a lot of stuff on Homebrew Hub, but the logic I added is pretty much all over the place. If you have some ideas on how to make this more modular/maintainable I'd be happy to follow up on your suggestions |
Uh oh!
There was an error while loading. Please reload this page.