Skip to content

feat: optionParent Select.js custom element #6643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v1-dev
Choose a base branch
from
Open

feat: optionParent Select.js custom element #6643

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions js/select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,10 @@
/**
* Options for the select
* @member FormSelect#options
* @prop {Element} optionParent [optionParent=<element>] - Parent element to scan option and optgroup elements from,
* default is the select element itself (optional)
*/
this.options = $.extend({}, FormSelect.defaults, options);
this.options = $.extend({ optionParent: this.$el }, FormSelect.defaults, options);

this.isMultiple = this.$el.prop('multiple');

Expand Down Expand Up @@ -182,7 +184,7 @@
}

// Create dropdown
this.$selectOptions = this.$el.children('option, optgroup');
this.$selectOptions = $(this.options.optionParent).children('option, optgroup');
this.dropdownOptions = document.createElement('ul');
this.dropdownOptions.id = `select-options-${M.guid()}`;
$(this.dropdownOptions).addClass(
Expand Down Expand Up @@ -214,6 +216,10 @@
this._addOptionToValueDict(el, optionEl);
});
}

if (this.options.optionParent != this.$el[0]) {
this.el.appendChild(el);
}
});
}

Expand Down