Skip to content

Conversation

dkazanc
Copy link
Collaborator

@dkazanc dkazanc commented Aug 20, 2025

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation

@yousefmoazzam
Copy link
Collaborator

The small data pipeline tests that are failing in CI, running them locally outside of pytest shows that the reason the MPI abort is called is because of incorrect args being passed to a tomobar recon function:

TypeError: RecToolsDIRCuPy.__init__() missing 1 required positional argument: 'DetectorsDimH_pad'

I imagine that this is because the httomo CI is pulling in the latest tomobar version on PyPI which has the breaking changes to the recon method's function signatures, but httomolibgpu hasn't yet gotten a new release that accommodates for those changes, which makes the YAML templates generated (and thus the full pipelines generated from the YAML templates + full pipeline directives) for the tomobar methods be based on the old function signatures.

Waiting for the httomolibgpu PR to get merged (DiamondLightSource/httomolibgpu#220) and a subsequent release of httomolibgpu should fix the failing small data pipeline tests here.

@dkazanc dkazanc merged commit 1a4f9eb into main Sep 5, 2025
3 of 4 checks passed
@dkazanc dkazanc deleted the tomobarpadding branch September 5, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants