Skip to content

Conversation

oliwenmandiamond
Copy link
Contributor

Fixes #1579

Instructions to reviewer on how to test:

  1. Check tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@oliwenmandiamond oliwenmandiamond requested a review from a team as a code owner October 1, 2025 13:15
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.87%. Comparing base (17b1eb4) to head (535020c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1592      +/-   ##
==========================================
- Coverage   98.88%   98.87%   -0.01%     
==========================================
  Files         260      260              
  Lines        9469     9461       -8     
==========================================
- Hits         9363     9355       -8     
  Misses        106      106              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. That CI failure is unrelated I think

@oliwenmandiamond oliwenmandiamond merged commit 83fc820 into main Oct 6, 2025
19 of 20 checks passed
@oliwenmandiamond oliwenmandiamond deleted the simplify_electron_analyser_driver_reference branch October 6, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify ElectronAnalyserDetector driver reference
2 participants