-
Notifications
You must be signed in to change notification settings - Fork 12
Created a dcm as a baseline device for i11 #1581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1581 +/- ##
=======================================
Coverage 98.82% 98.82%
=======================================
Files 250 251 +1
Lines 8992 9025 +33
=======================================
+ Hits 8886 8919 +33
Misses 106 106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we able to use a signal on the superclass for a derived_signal
? If not, I think wavelength could/should be added to the superclass for all to benefit from.
Co-authored-by: Joseph Ware <[email protected]>
Co-authored-by: Joseph Ware <[email protected]>
Created a dcm for i11. Intended for use as a baseline device