Skip to content

Conversation

fajinyuan
Copy link
Contributor

add see also for SSG and MMG beamlines requirements.

Fixes #ISSUE

Instructions to reviewer on how to test:

  1. please recommend way to comment on .md or .rst doc
  2. request to check current content in sync with further requirenments

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

add see also for SSG and MMG beamlines requirements.
@fajinyuan fajinyuan requested a review from a team as a code owner September 17, 2025 14:03
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.74%. Comparing base (24a51cf) to head (8771e20).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1544   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         242      242           
  Lines        8747     8747           
=======================================
  Hits         8637     8637           
  Misses        110      110           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DominicOram
Copy link
Contributor

It's my understanding that the discussion you've linked is proposing to change the decision in the ADR? That's fine, happy to have the discussion on changing the ADR but by just adding the link here it seems confusing that we now have an ADR saying we should do X that links to an issue that says "no, do Y"

@fajinyuan
Copy link
Contributor Author

Sorry about this. I was trying to find a way to add as comment to the doc propose, but cannot find a way on the doc page, so I thought just add as a last line in also see in the doc so the requirements will not be forgot.
So what you say here is I should create a issue instead, after creating the issue how do I make sure this issue is linked with the original propose in the doc so it will not be missed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants