-
Notifications
You must be signed in to change notification settings - Fork 12
Move shared i10 and i10-1 devices to i10_shared #1534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DG-At-Diamond
wants to merge
12
commits into
main
Choose a base branch
from
I10_1-PGM
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1534 +/- ##
==========================================
+ Coverage 98.79% 98.88% +0.09%
==========================================
Files 260 263 +3
Lines 9464 9540 +76
==========================================
+ Hits 9350 9434 +84
+ Misses 114 106 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
12 tasks
This was
linked to
issues
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes sim-bluesky Issue #111, #1560
@DG-At-Diamond is on holiday so @Relm-Arrowny completed the rest of the issue. I have split the rest of the i10 devices and fixed the file not found issue due to mocking the wrong folder as we have moved ids to i10-optics.
I have also added all in device.i10 for easier import.
Instructions to reviewer on how to test:
Check shared config file can be loaded by both and all devices in i10_shared are actually shared