fix playwright >=1.53 hanging issue caused by global fake module variable not being deleted after the selector engine is registered
#53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not being deleted after the selector engine is registered
DetachHead
changed the title
module variable not being deleted after the selector engine is registeredmodule variable not being deleted after the selector engine is registered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was causing very strange issues on one of the sites at work. it was intermittently hanging after navigating to a page if the next playwright action uses a custom selector engine.
i'm not sure exactly what was going on, but i don't think it's safe to mess with the globals without cleaning it up afterwards anyway