Add long-press / shift-click item popup to item picker #10717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhollis
force-pushed
the
long-press-item-picker
branch
from
c40ecac to
957a455
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a long-press / shift-click action to items in the item pickers (used for pull items and picking loadout items). This allows you to open the item popup from those pages to check what's up with the items.
This is what I intended when the item picker was first built but I never got around to it. In my opinion this is less distracting than hover popups a la #7673. However, it is much less discoverable. A dismissible hint text in the item pickers is unpleasant but might be warranted here. On the other hand, nobody reads the hint texts...