Skip to content

Conversation

snieguu
Copy link
Contributor

@snieguu snieguu commented May 15, 2025

Description

Make PUT api/oidc/mapping idempotent as it should be

Addressed Issue

Fixes #4950

Additional Details

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@owasp-dt-bot
Copy link

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d074969) 24029 19374 80.63%
Head commit (f6dfdd7) 24030 (+1) 19375 (+1) 80.63% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4966) 3 3 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@robertas90poe
Copy link

Hi! How's a progress with this one? It hasn't been merged since May 15?!? Is it going to be ever?

@nscuro nscuro added the defect Something isn't working label Oct 22, 2025
@nscuro nscuro added this to the 4.14.0 milestone Oct 22, 2025
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping, sorry this went under.

@nscuro nscuro merged commit 62717b8 into DependencyTrack:master Oct 22, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

defect Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PUT oidc/mapping is not indempotent

4 participants