Rebased 'schematron' onto 'issue-144' #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- causes 'as' attribute values to use XPath syntax-highlighting - completionProvider will need fixing - xslTokenDiagnostics will need fixing
…okens within the 'as' attribute value, now that the attribute value is tokenised
…e 'simpleType' - even if the value does not match a simple type - this allows xsltTokenDiagnostirs to report errors if the token value does not match a type name like 'xs:integer'
… attribute to be neutral - so make the token types nodeType and simpleType have a 'string' type in the semanticTokenTypes 'superType' declaration
…n type to be simpleType and not anonymousFunction
does not cause a 'missing context-item' error
…xed with '~' character 2. don't report error for 'xs:anyAtomicType' - it doesn't have a constructor
…ookup: e.g. on 'key1': $val?key1?key2
…ML schema we cannot easily get the set of defined types, so, provided the type's namespace is declared, report no error
…mmit, we need to check the full list of bound namespace prefixes, not just the xsltPrefixes
… completion-list the updated item would be xs:xs:string - must not dupe the type prefix
…bute 2. show error for types not expected when withinTypeDeclarationAttr is true
- this helps the linter
…pleType' check that 'book' is a valid node-name
…r, xs:integer) or too few: e.g. map ( ) - TODO: 'map()' (no space char between brackets)
2. detect problem with map() or array()
provide meaningful error message with new error type
|
I've never used rebase myself, so accepted the pull-request with some trepidation, but this has done what I think both you and I hoped it would. The issue-144 branch changes are now included on the schematron branch and 'master' is unaffected. |
|
I don't know whether it was visible to you, but I forked, rebased, then deleted the fork 2-3 times before I got something that didn't also repeat all of the 'issue-144' commits on the 'schematron' branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'issue-144' is the future. See #150
Hopefully this doesn't tie GitHub's 'Network Graph' in knots.