Perf - prevent memory leak in withTimeout utility #10893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0saurabh0
commented
Oct 27, 2025
| const timeout = new Promise((_, reject) => { | ||
| timeoutId = setTimeout(() => { | ||
| reject(`${id} timed out after ${millis / 1000} s.`); | ||
| resolve; |
There was a problem hiding this comment.
This resolve was not doing anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
withTimeoutfunction creates a timeout promise that rejects after a delay, but theresolvecallback is placed on a separate line without being called. This means the timeout is never cleared even when the main promise completes first, this can cause memory leaks and zombie timers.Fix :