add tvl for mstable v2 #16500

paveltimosh · 2025-10-01T07:38:09Z

NOTE

Please enable "Allow edits by maintainers" while putting up the PR.

If you would like to add a volume/fees/revenue adapter please submit the PR here.

If you would like to add a liquidations adapter, please refer to this readme document for details.

Once your adapter has been merged, it takes time to show on the UI. If more than 24 hours have passed, please let us know in Discord.
Sorry, We no longer accept fetch adapter for new projects, we prefer the tvl to computed from blockchain data, if you have trouble with creating a the adapter, please hop onto our discord, we are happy to assist you.
Please fill the form below only if the PR is for listing a new protocol else it can be ignored/replaced with reason/details about the PR
For updating listing info It is a different repo, you can find your listing in this file: https://github.com/DefiLlama/defillama-server/blob/master/defi/src/protocols/data2.ts, you can edit it there and put up a PR
Do not edit/push package-lock.json file as part of your changes, we use lockfileVersion 2, and most use v1 and using that messes up our CI
No need to go to our discord and announce that you've created a PR, we monitor all PRs and will review it asap

Name (to be shown on DefiLlama):

Twitter Link:

List of audit links if any:

Website Link:

Logo (High resolution, will be shown with rounded borders):

Current TVL:

Treasury Addresses (if the protocol has treasury)

Chain:

Coingecko ID (so your TVL can appear on Coingecko, leave empty if not listed): (https://api.coingecko.com/api/v3/coins/list)

Coinmarketcap ID (so your TVL can appear on Coinmarketcap, leave empty if not listed): (https://api.coinmarketcap.com/data-api/v3/map/all?listing_status=active,inactive,untracked&start=1&limit=10000)

Short Description (to be shown on DefiLlama):

Token address and ticker if any:

Category (full list at https://defillama.com/categories) *Please choose only one:

Oracle Provider(s): Specify the oracle(s) used (e.g., Chainlink, Band, API3, TWAP, etc.):

Implementation Details: Briefly describe how the oracle is integrated into your project:

Documentation/Proof: Provide links to documentation or any other resources that verify the oracle's usage:

forkedFrom (Does your project originate from another project):

methodology (what is being counted as tvl, how is tvl being calculated):

Github org/user (Optional, if your code is open source, we can track activity):

llamabutler · 2025-10-01T07:38:36Z

The adapter at projects/mstable-v2 exports TVL:

ethereum                  2.66 M

total                    2.66 M

waynebruce0x · 2025-10-01T13:53:13Z

projects/mstable-v2/index.js

+    );
+
+    return {
+        tether: totalValue / 1e18,


can we count token balances in the pools instead?

Pools can contain comples positions like aave lending v3 or pendle, not only base assets. So its better to show only total pool usd value.

we track aave v3 and pendle assets

Oh, I see, but could you please add it to new page "mStable V2" astotal usd values?

can you please refactor the adapter to return balances of the underlying tokens instead of a USD value?

But I got only 5k$

I dont think 0x87870bca3f3fd6335c3f4ce8392d69350b4fa4e2 is an erc20?

Yes, it's not ERC-20. So waht to do, revert it total usd value without asset balances?

It will have no price then. We only price ER20s and some NFTs. To track Aave deposits you should be exporting a balance of a tokens

@waynebruce0x fixed, please review

waynebruce0x · 2025-10-09T12:41:06Z

Error in ethereum: TypeError: Cannot read properties of null (reading 'assets')
    at /home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/projects/mstable-v2/index.js:38:28
    at Array.map (<anonymous>)
    at getLockedAssetsForFunds (/home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/projects/mstable-v2/index.js:37:29)

Is this expected? Does this run successfully when you test?

paveltimosh · 2025-10-09T13:13:00Z

@waynebruce0x Yes, the test passed successfully during local run

waynebruce0x · 2025-10-09T15:07:08Z

projects/mstable-v2/index.js

+    const fundCompositions = await api.multiCall({
+        abi: MSTABLE_POOL_MANAGER_LOGIC_ABI,
+        calls: poolManagerLogicAddresses,
+        permitFailure: true


The adapter doesnt run. When a call here fails (currently the third call) it returns null. Then the following map fails because there is no 'assets' on null

Added checking for not null.C ould you please send the output of the adapter before merging the PR?

Error in ethereum: TypeError: Cannot read properties of null (reading 'assets')
at /home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/projects/mstable-v2/index.js:38:25
at Array.map ()
at getLockedAssetsForFunds (/home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/projects/mstable-v2/index.js:37:29)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async tvlForChain (/home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/projects/mstable-v2/index.js:74:27)
at async getTvl (/home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/test.js:53:21)
at async /home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/test.js:172:11
at async Promise.all (index 0)
at async Promise.all (index 3)
at async /home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/test.js:198:3

https://github.com/DefiLlama/DefiLlama-Adapters/actions/runs/18386046228/job/52384618140?pr=16500#step:4:62

waynebruce0x · 2025-10-10T10:03:39Z

projects/mstable-v2/index.js

-            (lockedTokens, [address], i) => ({ ...lockedTokens, [address]: composition.balances[i] }),
-        {},
-        )
+        if (composition.assets) {


if (composition) {

add tvl for mstable v2

306941d

waynebruce0x reviewed Oct 1, 2025

View reviewed changes

waynebruce0x self-assigned this Oct 1, 2025

paveltimosh mentioned this pull request Oct 2, 2025

Add fees and revenue for mstable v2 DefiLlama/dimension-adapters#4322

Open

paveltimosh added 2 commits October 7, 2025 13:33

return assets balances for funds

2c97ec5

add tracking aave v3 positions

b67963b

waynebruce0x reviewed Oct 9, 2025

View reviewed changes

add checking not null

8f34cdf

waynebruce0x reviewed Oct 10, 2025

View reviewed changes

fix not null

23ed256

add tvl for mstable v2 #16500

Are you sure you want to change the base?

add tvl for mstable v2 #16500

Conversation

paveltimosh commented Oct 1, 2025

Please enable "Allow edits by maintainers" while putting up the PR.

Name (to be shown on DefiLlama):

Twitter Link:

List of audit links if any:

Website Link:

Logo (High resolution, will be shown with rounded borders):

Current TVL:

Treasury Addresses (if the protocol has treasury)

Chain:

Coingecko ID (so your TVL can appear on Coingecko, leave empty if not listed): (https://api.coingecko.com/api/v3/coins/list)

Coinmarketcap ID (so your TVL can appear on Coinmarketcap, leave empty if not listed): (https://api.coinmarketcap.com/data-api/v3/map/all?listing_status=active,inactive,untracked&start=1&limit=10000)

Short Description (to be shown on DefiLlama):

Token address and ticker if any:

Category (full list at https://defillama.com/categories) *Please choose only one:

Oracle Provider(s): Specify the oracle(s) used (e.g., Chainlink, Band, API3, TWAP, etc.):

Implementation Details: Briefly describe how the oracle is integrated into your project:

Documentation/Proof: Provide links to documentation or any other resources that verify the oracle's usage:

forkedFrom (Does your project originate from another project):

methodology (what is being counted as tvl, how is tvl being calculated):

Github org/user (Optional, if your code is open source, we can track activity):

Uh oh!

llamabutler commented Oct 1, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

paveltimosh Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

waynebruce0x commented Oct 9, 2025

Uh oh!

paveltimosh commented Oct 9, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

paveltimosh Oct 7, 2025 •

edited

Loading