Add support of non-secret configs #1619
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionello
changed the title
lionello
requested changes
Nov 9, 2025
| configSetCmd.Flags().BoolP("name", "n", false, "name of the config (backwards compat)") | ||
| configSetCmd.Flags().BoolP("env", "e", false, "set the config from an environment variable") | ||
| configSetCmd.Flags().Bool("random", false, "set a secure randomly generated value for config") | ||
| configSetCmd.Flags().Bool("secret", true, "set a secret config") |
Member
There was a problem hiding this comment.
Boolean flags with true as default are a little awkward since the only way to really use it is to say --secret=false, which can perhaps be considered a feature since you make it explicit that a config can be read?
|
|
||
| configCmd.AddCommand(configSetCmd) | ||
|
|
||
| configGetCmd.Flags().BoolP("name", "n", false, "name of the config") |
Member
There was a problem hiding this comment.
I'd do this using positional arg(s). For a while we only had -n so I had changed that to be a boolean, so it's effectively ignored.
Suggested change
| configGetCmd.Flags().BoolP("name", "n", false, "name of the config") |
| // Exec(ctx context.Context, taskID TaskID, args ...string) error | ||
| GetInfo(ctx context.Context, taskID TaskID) (*TaskInfo, error) | ||
| PutSecret(ctx context.Context, name, value string) error | ||
| PutSecret(ctx context.Context, encrypt bool, name, value string) error |
Member
There was a problem hiding this comment.
Actually, they are always encrypted, regardless of whether you can read back or not, so this is a misnomer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1618
Add back the non-secret config functionality.
This was previous approved but revert to allow for more testing time.