-
Notifications
You must be signed in to change notification settings - Fork 20
add last 30 terminal outputs for tracking for errors on command #1529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… add terminal logs to tracking leading up to debug prompt.
…circular buffer a generic
Co-authored-by: Jordan Stephens <[email protected]>
Co-authored-by: Jordan Stephens <[email protected]>
Co-authored-by: Lio李歐 <[email protected]>
jordanstephens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, these argument lists are getting long and threading the cache through each layer is adding a lot of complexity. I think this is getting complex enough to warrant creation of a log client struct that can has properties for the provider client and the cache. But given how many of us are working in this code right now, I think its best to do this in isolation in a followup.
|
Update: This PR is on hold. As mentioned above the threading of the logCache and the size of some of the function signatures is cumbersome. Additionally, this may not be the best way to log build breaks for analysis. |
Description
When CLI errors occur we don't always have a good idea of why it happens as we do not have customer deployment information. By including the last 10 lines of their terminal output when an error occurs on a command or before the AI debugger prompt we can hope to get some context on why they have a failure.
This PR includes
add the terminal output to tracking command events which has a failureadd the terminal output to tracking of when the debugger promptLinked Issues
fixes #2291
Checklist