Skip to content

Added support for NES controller. #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added support for NES controller. #1220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98e1ae4
Added support for NES controller.
ConnorS-P May 15, 2025
b2321d8
Fixed incorrect logic for determining NES controller.
ConnorS-P May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions BetterJoyForCemu/BetterJoy.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,7 @@
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</Content>
<Content Include="Icons\snes.png" />
<Content Include="Icons\nes.png" />
<Content Include="Icons\ultra.png" />
<None Include="Properties\app.manifest" />
<Content Include="Icons\betterjoyforcemu_icon.ico" />
Expand Down
Binary file added BetterJoyForCemu/Icons/nes.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
43 changes: 34 additions & 9 deletions BetterJoyForCemu/Joycon.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ public class Joycon {
public string path = String.Empty;
public bool isPro = false;
public bool isSnes = false;
public bool isNes = false;
public bool is64 = false;
bool isUSB = false;
private Joycon _other = null;
Expand Down Expand Up @@ -438,6 +439,28 @@ public int Attach() {
Subcommand(0x48, new byte[] { 0x01 }, 1);

Subcommand(0x3, new byte[] { 0x30 }, 1);

//Make sure we're not actually a nes controller
if (!this.isLeft) {
byte[] resp;

for (int i = 0; i < 100; ++i) {
resp = Subcommand(0x02, Array.Empty<byte>(), 0, false, 200);

if (resp.Length >= 20 && resp[0] == 0x21 && resp[14] == 0x02)
{
if (resp[17] == 0x0A || resp[17] == 0x09) //NES controllers share the Right hardware ID of the right joycon, but respond here differently.
{
this.isLeft = true;
this.isPro = true;
this.isNes = true;
}

break;
}
}
}

DebugPrint("Done with init.", DebugType.COMMS);

HIDapi.hid_set_nonblocking(handle, 1);
Expand Down Expand Up @@ -510,7 +533,7 @@ private void BatteryChanged() { // battery changed level

if (battery <= 1) {
form.notifyIcon.Visible = true;
form.notifyIcon.BalloonTipText = String.Format("Controller {0} ({1}) - low battery notification!", PadId, isPro ? "Pro Controller" : (isSnes ? "SNES Controller" : (is64? "N64 Controller" : (isLeft ? "Joycon Left" : "Joycon Right"))));
form.notifyIcon.BalloonTipText = String.Format("Controller {0} ({1}) - low battery notification!", PadId, isPro ? "Pro Controller" : isNes ? "NES Controller" : isLeft ? "Joycon Left" : "Joycon Right");
form.notifyIcon.ShowBalloonTip(0);
}
}
Expand Down Expand Up @@ -599,7 +622,7 @@ private int ReceiveRaw() {
}


if (ts_en == raw_buf[1] && !(isSnes || is64)) {
if (ts_en == raw_buf[1] && !(isSnes || isNes || is64)) {
form.AppendTextBox("Duplicate timestamp enqueued.\r\n");
DebugPrint(string.Format("Duplicate timestamp enqueued. TS: {0:X2}", ts_en), DebugType.THREADING);
}
Expand Down Expand Up @@ -906,7 +929,7 @@ private void Poll() {

private int ProcessButtonsAndStick(byte[] report_buf) {
if (report_buf[0] == 0x00) throw new ArgumentException("received undefined report. This is probably a bug");
if (!isSnes) {
if (!isSnes && !isNes) {
stick_raw[0] = report_buf[6 + (isLeft ? 0 : 3)];
stick_raw[1] = report_buf[7 + (isLeft ? 0 : 3)];
stick_raw[2] = report_buf[8 + (isLeft ? 0 : 3)];
Expand Down Expand Up @@ -1019,7 +1042,7 @@ private int ProcessButtonsAndStick(byte[] report_buf) {

// Get Gyro/Accel data
private void ExtractIMUValues(byte[] report_buf, int n = 0) {
if (!(isSnes || is64)) {
if (!(isSnes || is64 || isNes)) {
gyr_r[0] = (Int16)(report_buf[19 + n * 12] | ((report_buf[20 + n * 12] << 8) & 0xff00));
gyr_r[1] = (Int16)(report_buf[21 + n * 12] | ((report_buf[22 + n * 12] << 8) & 0xff00));
gyr_r[2] = (Int16)(report_buf[23 + n * 12] | ((report_buf[24 + n * 12] << 8) & 0xff00));
Expand Down Expand Up @@ -1167,7 +1190,7 @@ private void SendRumble(byte[] buf) {
HIDapi.hid_write(handle, buf_, new UIntPtr(report_len));
}

private byte[] Subcommand(byte sc, byte[] buf, uint len, bool print = true) {
private byte[] Subcommand(byte sc, byte[] buf, uint len, bool print = true, int retries = 10) {
byte[] buf_ = new byte[report_len];
byte[] response = new byte[report_len];
Array.Copy(default_buf, 0, buf_, 2, 8);
Expand All @@ -1185,13 +1208,13 @@ private byte[] Subcommand(byte sc, byte[] buf, uint len, bool print = true) {
if (res < 1) DebugPrint("No response.", DebugType.COMMS);
else if (print) { PrintArray(response, DebugType.COMMS, report_len - 1, 1, "Response ID 0x" + string.Format("{0:X2}", response[0]) + ". Data: 0x{0:S}"); }
tries++;
} while (tries < 10 && response[0] != 0x21 && response[14] != sc);
} while (tries < retries && response[0] != 0x21 && response[14] != sc);

return response;
}

private void dump_calibration_data() {
if (isSnes || is64 || thirdParty) {
if (isSnes || is64 || thirdParty || isNes) {
short[] temp = (short[])ConfigurationManager.AppSettings["acc_sensiti"].Split(',').Select(s => short.Parse(s)).ToArray();
acc_sensiti[0] = temp[0]; acc_sensiti[1] = temp[1]; acc_sensiti[2] = temp[2];
temp = (short[])ConfigurationManager.AppSettings["gyr_sensiti"].Split(',').Select(s => short.Parse(s)).ToArray();
Expand Down Expand Up @@ -1431,6 +1454,7 @@ private static OutputControllerXbox360InputState MapToXbox360Input(Joycon input)
var isPro = input.isPro;
var isLeft = input.isLeft;
var isSnes = input.isSnes;
var isNes = input.isNes;
var is64 = input.is64;
var other = input.other;
var GyroAnalogSliders = input.GyroAnalogSliders;
Expand Down Expand Up @@ -1528,7 +1552,7 @@ private static OutputControllerXbox360InputState MapToXbox360Input(Joycon input)
if (Config.Value("home") != "0")
output.guide = false;

if (!(isSnes || is64)) {
if (!(isSnes || is64 || isNes)) {
if (other != null || isPro) { // no need for && other != this
output.axis_left_x = CastStickValue((other == input && !isLeft) ? stick2[0] : stick[0]);
output.axis_left_y = CastStickValue((other == input && !isLeft) ? stick2[1] : stick[1]);
Expand Down Expand Up @@ -1566,6 +1590,7 @@ public static OutputControllerDualShock4InputState MapToDualShock4Input(Joycon i
var isPro = input.isPro;
var isLeft = input.isLeft;
var isSnes = input.isSnes;
var isNes = input.isNes;
var is64 = input.is64;
var other = input.other;
var GyroAnalogSliders = input.GyroAnalogSliders;
Expand Down Expand Up @@ -1704,7 +1729,7 @@ public static OutputControllerDualShock4InputState MapToDualShock4Input(Joycon i
if (Config.Value("home") != "0")
output.ps = false;

if (!(isSnes || is64)) {
if (!(isSnes || is64 || isNes)) {
if (other != null || isPro) { // no need for && other != this
output.thumb_left_x = CastStickValueByte((other == input && !isLeft) ? -stick2[0] : -stick[0]);
output.thumb_left_y = CastStickValueByte((other == input && !isLeft) ? stick2[1] : stick[1]);
Expand Down
57 changes: 33 additions & 24 deletions BetterJoyForCemu/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,8 @@ public void CheckForNewControllers() {
case (product_l):
temp = Properties.Resources.jc_left_s; break;
case (product_r):
temp = Properties.Resources.jc_right_s; break;
temp = Properties.Resources.jc_right_s;
break;
case (product_pro):
temp = Properties.Resources.pro; break;
case (product_snes):
Expand Down Expand Up @@ -254,6 +255,36 @@ public void CheckForNewControllers() {

ptr = enumerate.next;
}

bool on = ConfigurationManager.OpenExeConfiguration(ConfigurationUserLevel.None).AppSettings.Settings["HomeLEDOn"].Value.ToLower() == "true";
foreach (Joycon jc in j) { // Connect device straight away
if (jc.state == Joycon.state_.NOT_ATTACHED) {
if (jc.out_xbox != null)
jc.out_xbox.Connect();
if (jc.out_ds4 != null)
jc.out_ds4.Connect();

try {
jc.Attach();
} catch (Exception e) {
jc.state = Joycon.state_.DROPPED;
continue;
}

jc.SetHomeLight(on);

jc.Begin();
if (form.allowCalibration) {
jc.getActiveData();
}
}
}

foreach (Button b in form.con) {
if (b.Enabled && b.Tag is Joycon jc && jc.isNes) {
b.BackgroundImage = Properties.Resources.nes;
}
}

if (foundNew) { // attempt to auto join-up joycons on connection
Joycon temp = null;
Expand Down Expand Up @@ -303,29 +334,7 @@ public void CheckForNewControllers() {

HIDapi.hid_free_enumeration(top_ptr);

bool on = ConfigurationManager.OpenExeConfiguration(ConfigurationUserLevel.None).AppSettings.Settings["HomeLEDOn"].Value.ToLower() == "true";
foreach (Joycon jc in j) { // Connect device straight away
if (jc.state == Joycon.state_.NOT_ATTACHED) {
if (jc.out_xbox != null)
jc.out_xbox.Connect();
if (jc.out_ds4 != null)
jc.out_ds4.Connect();

try {
jc.Attach();
} catch (Exception e) {
jc.state = Joycon.state_.DROPPED;
continue;
}

jc.SetHomeLight(on);

jc.Begin();
if (form.allowCalibration) {
jc.getActiveData();
}
}
}

}

public void OnApplicationQuit() {
Expand Down
Loading