Skip to content

Conversation

bentivoglid
Copy link
Contributor

What does this PR do?

This PR adds the ability to specify additional volumes for the container in order to customize the fluentbit configuration and potentially log files in tail mode.

Motivation

In special cases, configuration modifications may be required, as "S3" mode is not available in FARGATE mode: https://docs.aws.amazon.com/AmazonECS/latest/
developerguide/firelens-taskdef.html#firelens-taskdef-customconfig

Additionally, this is necessary when you need to forward information from log files written by the application to the platform (or other outputs).

Describe how you validated your changes

Plan & Apply executed in our configuration. Default values for new properties are equals to hardcoded values in previous version.

@bentivoglid bentivoglid requested a review from a team as a code owner September 15, 2025 18:12
@gabedos
Copy link
Collaborator

gabedos commented Sep 15, 2025

Hey @bentivoglid! Thanks for opening this PR to further improve log configuration with the Datadog ECS Fargate Terraform module. Whenever you have the chance, could you run the make docs command to update our public documentation for the new options you've exposed.

@gabedos
Copy link
Collaborator

gabedos commented Sep 16, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Sep 16, 2025

View all feedbacks in Devflow UI.

2025-09-16 13:40:01 UTC ℹ️ Start processing command /merge


2025-09-16 13:40:15 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-09-16 13:41:35 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 0s (p90).


2025-09-16 13:44:21 UTC 🚨 MergeQueue: This merge request is in error

mergequeue build completed successfully, but the github api returned an error while merging the pr

Details

Error: PUT https://api.github.com/repos/DataDog/terraform-aws-ecs-datadog/pulls/44/merge: 405 Merge commits are not allowed on this repository. [] (Request ID: 8D12:DA8CE:3946BBF:CC560DC:68C969AE)

FullStacktrace:
activity error (type: github.GithubService_MergePullRequest, scheduledEventID: 41, startedEventID: 42, identity: 1@github-worker-56c947fbbd-82pjj@): PUT https://api.github.com/repos/DataDog/terraform-aws-ecs-datadog/pulls/44/merge: 405 Merge commits are not allowed on this repository. [] (Request ID: 8D12:DA8CE:3946BBF:CC560DC:68C969AE) (type: GitFailure, retryable: false): PUT https://api.github.com/repos/DataDog/terraform-aws-ecs-datadog/pulls/44/merge: 405 Merge commits are not allowed on this repository. [] (type: ErrorResponse, retryable: true)

Copy link
Collaborator

@gabedos gabedos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @bentivoglid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants