Skip to content

Conversation

@gabedos
Copy link
Collaborator

@gabedos gabedos commented Aug 14, 2025

What does this PR do?

Bumps the minimum AWS provider version for the ecs_fargate module to >=5.85.0

Motivation

The enable_fault_injection parameter in the fargate task definition on Terraform was introduced in the 5.85.0 version of the provider. Users with a lower version have an error thrown when attempting to use this module.

CONTP-936 #29

Describe how you validated your changes

Manually set the AWS provider to fixed versions

terraform {
  required_version = ">= 1.5.0"

  required_providers {
    aws = {
      source  = "hashicorp/aws"
      version = "5.85.0"
    }
  }
}

Then verify that the terraform plan command does not throw any errors from the AWS provider.

Additional Notes

Also updated the structure for the make docs command to execute in the manual pre-commit stage for all submodules (currently only ecs_fargate)

@gabedos gabedos requested a review from a team as a code owner August 14, 2025 19:25
@gabedos gabedos force-pushed the gabedos/update-minimum-compatible-version branch from 35a5c29 to 721ae9d Compare August 14, 2025 19:27
@gabedos
Copy link
Collaborator Author

gabedos commented Aug 19, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Aug 19, 2025

View all feedbacks in Devflow UI.

2025-08-19 20:28:19 UTC ℹ️ Start processing command /merge


2025-08-19 20:28:26 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 0s (p90).


2025-08-19 20:30:51 UTC 🚨 MergeQueue: This merge request is in error

mergequeue build completed successfully, but the github api returned an error while merging the pr

Details

Error: PUT https://api.github.com/repos/DataDog/terraform-aws-ecs-datadog/pulls/30/merge: 405 Merge commits are not allowed on this repository. [] (Request ID: DAD6:AF8E9:A9D3EC:263C7E3:68A4DEF5)

FullStacktrace:
activity error (type: github.GithubService_MergePullRequest, scheduledEventID: 41, startedEventID: 42, identity: 1@github-worker-bd578fd9b-6lmbq@): PUT https://api.github.com/repos/DataDog/terraform-aws-ecs-datadog/pulls/30/merge: 405 Merge commits are not allowed on this repository. [] (Request ID: DAD6:AF8E9:A9D3EC:263C7E3:68A4DEF5) (type: GitFailure, retryable: false): PUT https://api.github.com/repos/DataDog/terraform-aws-ecs-datadog/pulls/30/merge: 405 Merge commits are not allowed on this repository. [] (type: ErrorResponse, retryable: true)

@gabedos gabedos merged commit d20ee1f into main Aug 19, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants