Skip to content

Conversation

@gyuheon0h
Copy link

@gyuheon0h gyuheon0h commented Oct 22, 2025

Motivation

Related to this https://datadoghq.atlassian.net/browse/INPLAT-603

Changes

  1. Update JSON schema for crash report; The payload field of the telemetry log is an Array, as seen in the examples attached to this JIRA ticket. We should validate correctly, but I kept the previous schema for backwards compatibility.
  2. Added /crashme endpoints for node and python test app. This is because, when debugging the test that fails in CI locally in workspaces, I noticed that the test behavior was different depending on whether I ran the failing test as part of the default scenario, or the specific docker_ssi_crashtracking scenario. The test seemed to fail when run all together, but when run specifically within its scenario, it would pass. I updated the test setup code to simply use Weblog for whatever scenario env it is currently in.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2025

CODEOWNERS have been resolved as:

utils/build/docker/nodejs/express/app.js                                @DataDog/dd-trace-js @DataDog/system-tests-core
utils/build/docker/python/flask/app.py                                  @DataDog/apm-python @DataDog/asm-python @DataDog/system-tests-core

@gyuheon0h gyuheon0h force-pushed the gyuheon0h/prof-12799-python-sys-tests branch from 1be7fb9 to 2e37e96 Compare October 24, 2025 13:06
Copy link
Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@gyuheon0h gyuheon0h force-pushed the gyuheon0h/prof-12799-python-sys-tests branch from 2e37e96 to 504ee48 Compare October 24, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants