Add use_beta_encode_cookie_options to TelemetryConfigurationEvent #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mormubis
previously approved these changes
Nov 6, 2025
lib/cjs/generated/telemetry.d.ts
Outdated
| /** | ||
| * Whether the beta encode cookie options is enabled | ||
| */ | ||
| use_beta_encode_cookie_options?: boolean; |
Member
There was a problem hiding this comment.
this shouldn't start with use_. We only use use_ prefix when we can't serialize the configuration name in JSON or if it's sensitive.
Suggested change
| use_beta_encode_cookie_options?: boolean; | |
| beta_encode_cookie_options?: boolean; |
…n TelemetryConfigurationEvent type and schema for consistency.
aleksandr-gringauz
approved these changes
Nov 7, 2025
BenoitZugmeyer
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to release the encode cookie option behind a new beta init parameter
see DataDog/browser-sdk#3951