Skip to content

Conversation

@cbeauchesne
Copy link
Contributor

@cbeauchesne cbeauchesne commented Oct 23, 2025

What does this PR do?

It achieves two tasks :

  • Runs all existing weblogs on tracer_release scenario group:
    October 9th, a new version of the WAF has been pushed to dd-trace-rb. Turns out that this version was not passing a test (APPSEC-59579). But dd-trace-rb CI was running this test against the weblog rails70, which was removed at this time, so the issue was not seen during the PR. It showed that running a subset of scenarios/weblog is prone to errors like that, wihtout mentionning that it adds some maintenance on this list.
    -> By using tracer_release, the scenario and weblog list is delegated to system-tests, keeping the maintenance level to its minimum here. If for some reason set of scenario/weblog shall not be run, it will be addressed directly in system-tests.
  • Push test runs to Test Optimization

CI impact : the current pipeline takes ~16'30

The new pipeline :

  • run 1 : 18'40 (expected failure, I forgot to add a secret)
  • run 2 : 18'53

Change log entry
None.

Additional Notes:

How to test the change?

@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Oct 23, 2025
@github-actions
Copy link

github-actions bot commented Oct 23, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-10-23 14:58:49 UTC

@datadog-official
Copy link

datadog-official bot commented Oct 23, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 98.58% (+0.01%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: dcd1c3a | Docs | Was this helpful? Give us feedback!

@cbeauchesne cbeauchesne changed the title Cbeauchesne/system tests improvments system-tests improvments: simpler CI definition; Report to test optimization Oct 23, 2025
@cbeauchesne cbeauchesne added the dev/ci Involves CircleCI, GitHub Actions, or GitLab label Oct 23, 2025
@cbeauchesne cbeauchesne force-pushed the cbeauchesne/system-tests-improvments branch from 5f79e51 to dcd1c3a Compare October 23, 2025 14:21
@cbeauchesne cbeauchesne marked this pull request as ready for review October 23, 2025 14:43
@cbeauchesne cbeauchesne requested a review from a team as a code owner October 23, 2025 14:43
Copy link
Member

@y9v y9v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! thanks

@cbeauchesne cbeauchesne merged commit 7e292a6 into master Oct 24, 2025
564 checks passed
@cbeauchesne cbeauchesne deleted the cbeauchesne/system-tests-improvments branch October 24, 2025 08:36
@github-actions github-actions bot added this to the 2.23.0 milestone Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev/ci Involves CircleCI, GitHub Actions, or GitLab dev/github Github repository maintenance and automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants