Skip to content

Conversation

@emmettbutler
Copy link
Contributor

What does this PR do?

This change adds brief and generic documentation about how to handle test unreliability

Motivation:

This change aims to make it easier for new contributors to become effective in this repo.

Change log entry

Additional Notes:

How to test the change?

@emmettbutler emmettbutler requested a review from a team as a code owner June 20, 2025 20:34
@emmettbutler emmettbutler requested a review from TonyCTHsu June 20, 2025 20:34
@github-actions github-actions bot added the docs Involves documentation label Jun 20, 2025
@github-actions
Copy link

github-actions bot commented Jun 20, 2025

👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-06-24 12:11:48 UTC

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (4262c44) to head (565ee3d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4752   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files        1486     1486           
  Lines       88592    88592           
  Branches     4589     4589           
=======================================
+ Hits        86423    86425    +2     
+ Misses       2169     2167    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jun 20, 2025

Datadog Report

Branch report: emmett.butler/flaky-guidance
Commit report: 565ee3d
Test service: dd-trace-rb

✅ 0 Failed, 21774 Passed, 1296 Skipped, 5m 23.44s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jun 20, 2025

Benchmarks

Benchmark execution time: 2025-06-25 15:46:04

Comparing candidate commit 565ee3d in PR branch emmett.butler/flaky-guidance with baseline commit 4262c44 in branch master.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 43 metrics, 2 unstable metrics.

scenario:error - without error tracking with http

  • 🟥 throughput [-28.561op/s; -21.420op/s] or [-19.799%; -14.849%]

scenario:profiling - profiler gc

  • 🟥 throughput [-19882.866op/s; -19367.394op/s] or [-5.398%; -5.258%]

@p-datadog
Copy link
Member

We don't presently seem to run any tests for contributor PRs automatically (e.g. see: #4543). An employee has to push the code to this repo (which contribuotrs have no permission to do) for CI to run. I don't know if contributors will be able to restart any failing jobs either.

@TonyCTHsu
Copy link
Contributor

@p-datadog , @emmettbutler is employed at Datadog. The Gitlab job failed without useful information only doc changes pull request.

@TonyCTHsu TonyCTHsu changed the title add recipe for handling flaky tests [LANGPLAT-352] add recipe for handling flaky tests Jun 24, 2025
@emmettbutler emmettbutler merged commit 783b428 into master Jun 25, 2025
256 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/flaky-guidance branch June 25, 2025 16:19
@github-actions github-actions bot added this to the 2.18.0 milestone Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Involves documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants