fix(ci_visibility): do not use is_user_code [backport 3.15] #14810
Conversation
![dd-octo-sts[bot]](https://avatars.githubusercontent.com/in/1157446?s=80&v=4){kind=small}
dd-octo-sts
bot
requested review from
anmarchenko,
emmettbutler and
vitor-de-araujo
|
|
Currently, in Test Impact Analysis code coverage, we use `is_user_code()` to decide whether to instrument a module. This function was conceived for use in non-CI contexts where user code may be installed in site-packages like external dependencies. This is not necessary in Test Optimization, where we only want to cover code inside the current repo (TIA only works with filenames that are relative to the repo root, and we already set the repo root as the include path of `ModuleCodeCollector`). Removing this check also resolves a bug where test packages are incorrectly detected as third-party if a third-party package contains files under `test/*` or `tests/*` that get installed at site-packages level (`sumy` and `sendgrid` do this, for instance). Unit tests + manual testing in dogweb. Potentially covering more code than expected. Should not be an issue because we already exclude site-packages and similar [here](https://github.com/DataDog/dd-trace-py/blob/vitor-de-araujo%2FSDTEST-2747%2Fcoverage-third-party/ddtrace/internal/coverage/code.py#L53). None. (cherry picked from commit 7cd4d9c)
vitor-de-araujo
force-pushed
the
backport-14794-to-3.15
branch
from
4aa02ec to
ea642d9
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 270 ± 3 ms. The average import time from base is: 275 ± 5 ms. The import time difference between this PR and base is: -5.0 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate backport-14794-to-3.15 (eb0c182) with baseline 3.15 (f32c72b) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.406µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +1.0% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.6% ✅ add_inplace_aspectTime: ✅ 0.414µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +1.4% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ add_inplace_noaspectTime: ✅ 0.319µs (SLO: <10.000µs 📉 -96.8%) vs baseline: +0.7% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.8% ✅ add_noaspectTime: ✅ 0.280µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +1.2% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.8% ✅ bytearray_aspectTime: ✅ 1.339µs (SLO: <10.000µs 📉 -86.6%) vs baseline: -0.6% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.9% ✅ bytearray_extend_aspectTime: ✅ 1.460µs (SLO: <10.000µs 📉 -85.4%) vs baseline: +1.0% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.9% ✅ bytearray_extend_noaspectTime: ✅ 0.616µs (SLO: <10.000µs 📉 -93.8%) vs baseline: +0.2% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.6% ✅ bytearray_noaspectTime: ✅ 0.488µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +1.3% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ bytes_aspectTime: ✅ 1.324µs (SLO: <10.000µs 📉 -86.8%) vs baseline: +2.8% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ bytes_noaspectTime: ✅ 0.491µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.1% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ bytesio_aspectTime: ✅ 1.352µs (SLO: <10.000µs 📉 -86.5%) vs baseline: +2.1% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ bytesio_noaspectTime: ✅ 0.497µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.2% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ capitalize_aspectTime: ✅ 0.734µs (SLO: <10.000µs 📉 -92.7%) vs baseline: +0.4% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ capitalize_noaspectTime: ✅ 0.435µs (SLO: <10.000µs 📉 -95.6%) vs baseline: ~same Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ casefold_aspectTime: ✅ 0.735µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.4% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.9% ✅ casefold_noaspectTime: ✅ 0.369µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +1.0% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ decode_aspectTime: ✅ 0.730µs (SLO: <10.000µs 📉 -92.7%) vs baseline: +1.0% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ decode_noaspectTime: ✅ 0.420µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +0.4% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.8% ✅ encode_aspectTime: ✅ 0.706µs (SLO: <10.000µs 📉 -92.9%) vs baseline: ~same Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.6% ✅ encode_noaspectTime: ✅ 0.400µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.2% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ format_aspectTime: ✅ 3.443µs (SLO: <10.000µs 📉 -65.6%) vs baseline: ~same Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ format_map_aspectTime: ✅ 3.638µs (SLO: <10.000µs 📉 -63.6%) vs baseline: -0.9% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ format_map_noaspectTime: ✅ 0.780µs (SLO: <10.000µs 📉 -92.2%) vs baseline: +1.1% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ format_noaspectTime: ✅ 0.600µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +1.2% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.2% ✅ index_aspectTime: ✅ 0.358µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +0.9% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ index_noaspectTime: ✅ 0.279µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +1.2% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.6% ✅ join_aspectTime: ✅ 1.373µs (SLO: <10.000µs 📉 -86.3%) vs baseline: +1.1% Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +5.0% ✅ join_noaspectTime: ✅ 0.491µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.6% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ljust_aspectTime: ✅ 2.600µs (SLO: <20.000µs 📉 -87.0%) vs baseline: ~same Memory: ✅ 37.591MB (SLO: <39.000MB -3.6%) vs baseline: +4.6% ✅ ljust_noaspectTime: ✅ 0.410µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +1.1% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ lower_aspectTime: ✅ 2.221µs (SLO: <10.000µs 📉 -77.8%) vs baseline: +1.1% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ lower_noaspectTime: ✅ 0.368µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.5% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.8% ✅ lstrip_aspectTime: ✅ 2.272µs (SLO: <20.000µs 📉 -88.6%) vs baseline: +0.2% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.8% ✅ lstrip_noaspectTime: ✅ 0.382µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.1% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ modulo_aspectTime: ✅ 1.001µs (SLO: <10.000µs 📉 -90.0%) vs baseline: ~same Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.8% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.537µs (SLO: <10.000µs 📉 -84.6%) vs baseline: +0.4% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.9% ✅ modulo_aspect_for_bytesTime: ✅ 0.983µs (SLO: <10.000µs 📉 -90.2%) vs baseline: +0.5% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.204µs (SLO: <10.000µs 📉 -88.0%) vs baseline: +0.9% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.6% ✅ modulo_noaspectTime: ✅ 0.627µs (SLO: <10.000µs 📉 -93.7%) vs baseline: +0.1% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ replace_aspectTime: ✅ 4.931µs (SLO: <10.000µs 📉 -50.7%) vs baseline: +0.3% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ replace_noaspectTime: ✅ 0.460µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -0.5% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ repr_aspectTime: ✅ 0.902µs (SLO: <10.000µs 📉 -91.0%) vs baseline: -1.0% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ repr_noaspectTime: ✅ 0.415µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.8% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ rstrip_aspectTime: ✅ 1.970µs (SLO: <20.000µs 📉 -90.1%) vs baseline: +1.8% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.1% ✅ rstrip_noaspectTime: ✅ 0.378µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.2% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ slice_aspectTime: ✅ 0.490µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.5% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.8% ✅ slice_noaspectTime: ✅ 0.446µs (SLO: <10.000µs 📉 -95.5%) vs baseline: -0.3% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ stringio_aspectTime: ✅ 1.539µs (SLO: <10.000µs 📉 -84.6%) vs baseline: -0.2% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ stringio_noaspectTime: ✅ 0.719µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +0.2% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ strip_aspectTime: ✅ 2.577µs (SLO: <20.000µs 📉 -87.1%) vs baseline: 📈 +14.4% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ strip_noaspectTime: ✅ 0.384µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.2% Memory: ✅ 37.572MB (SLO: <39.000MB -3.7%) vs baseline: +4.5% ✅ swapcase_aspectTime: ✅ 2.435µs (SLO: <10.000µs 📉 -75.7%) vs baseline: +0.8% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ swapcase_noaspectTime: ✅ 0.539µs (SLO: <10.000µs 📉 -94.6%) vs baseline: +1.0% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ title_aspectTime: ✅ 2.431µs (SLO: <10.000µs 📉 -75.7%) vs baseline: +4.3% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.6% ✅ title_noaspectTime: ✅ 0.500µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.4% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ translate_aspectTime: ✅ 3.277µs (SLO: <10.000µs 📉 -67.2%) vs baseline: +1.3% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ translate_noaspectTime: ✅ 1.041µs (SLO: <10.000µs 📉 -89.6%) vs baseline: ~same Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ upper_aspectTime: ✅ 2.356µs (SLO: <10.000µs 📉 -76.4%) vs baseline: +6.5% Memory: ✅ 37.552MB (SLO: <39.000MB -3.7%) vs baseline: +4.4% ✅ upper_noaspectTime: ✅ 0.367µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.2% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.410µs (SLO: <10.000µs 📉 -55.9%) vs baseline: +1.1% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.9% ✅ ospathbasename_noaspectTime: ✅ 1.083µs (SLO: <10.000µs 📉 -89.2%) vs baseline: -0.6% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ ospathjoin_aspectTime: ✅ 6.167µs (SLO: <10.000µs 📉 -38.3%) vs baseline: +1.5% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.8% ✅ ospathjoin_noaspectTime: ✅ 2.286µs (SLO: <10.000µs 📉 -77.1%) vs baseline: ~same Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.8% ✅ ospathnormcase_aspectTime: ✅ 3.491µs (SLO: <10.000µs 📉 -65.1%) vs baseline: +0.2% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ ospathnormcase_noaspectTime: ✅ 0.573µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -0.5% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.2% ✅ ospathsplit_aspectTime: ✅ 5.115µs (SLO: <10.000µs 📉 -48.9%) vs baseline: +3.8% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.7% ✅ ospathsplit_noaspectTime: ✅ 1.591µs (SLO: <10.000µs 📉 -84.1%) vs baseline: +0.3% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ ospathsplitdrive_aspectTime: ✅ 4.272µs (SLO: <10.000µs 📉 -57.3%) vs baseline: 📈 +13.6% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathsplitdrive_noaspectTime: ✅ 0.706µs (SLO: <10.000µs 📉 -92.9%) vs baseline: -0.5% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ ospathsplitext_aspectTime: ✅ 4.632µs (SLO: <10.000µs 📉 -53.7%) vs baseline: ~same Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathsplitext_noaspectTime: ✅ 1.376µs (SLO: <10.000µs 📉 -86.2%) vs baseline: -1.8% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.5% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.104µs (SLO: <20.000µs 📉 -84.5%) vs baseline: -0.2% Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 213.144µs (SLO: <250.000µs 📉 -14.7%) vs baseline: +0.7% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.7% ✅ 1-distribution-metric-1-timesTime: ✅ 2.880µs (SLO: <20.000µs 📉 -85.6%) vs baseline: -0.7% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +5.2% ✅ 1-distribution-metrics-100-timesTime: ✅ 192.281µs (SLO: <220.000µs 📉 -12.6%) vs baseline: +0.7% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +5.2% ✅ 1-gauge-metric-1-timesTime: ✅ 2.069µs (SLO: <20.000µs 📉 -89.7%) vs baseline: +0.3% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.8% ✅ 1-gauge-metrics-100-timesTime: ✅ 124.733µs (SLO: <150.000µs 📉 -16.8%) vs baseline: +0.1% Memory: ✅ 32.067MB (SLO: <34.000MB -5.7%) vs baseline: +4.5% ✅ 1-rate-metric-1-timesTime: ✅ 3.526µs (SLO: <20.000µs 📉 -82.4%) vs baseline: 📈 +13.3% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.8% ✅ 1-rate-metrics-100-timesTime: ✅ 212.688µs (SLO: <250.000µs 📉 -14.9%) vs baseline: -0.2% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 21.351ms (SLO: <23.500ms -9.1%) vs baseline: -0.4% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +5.1% ✅ 100-distribution-metrics-100-timesTime: ✅ 1.987ms (SLO: <2.250ms 📉 -11.7%) vs baseline: -0.5% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.7% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.284ms (SLO: <1.550ms 📉 -17.2%) vs baseline: ~same Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.192ms (SLO: <2.550ms 📉 -14.0%) vs baseline: +0.4% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +5.1% ✅ flush-1-metricTime: ✅ 4.251µs (SLO: <20.000µs 📉 -78.7%) vs baseline: +1.4% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +5.1% ✅ flush-100-metricsTime: ✅ 181.777µs (SLO: <250.000µs 📉 -27.3%) vs baseline: +0.2% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ flush-1000-metricsTime: ✅ 2.211ms (SLO: <2.500ms 📉 -11.6%) vs baseline: +0.8% Memory: ✅ 32.893MB (SLO: <34.500MB -4.7%) vs baseline: +5.2% 🟡 Near SLO Breach (4 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.416ms (SLO: <22.300ms -8.4%) vs baseline: -0.3% Memory: ✅ 65.367MB (SLO: <67.000MB -2.4%) vs baseline: +4.9% ✅ exception-replay-enabledTime: ✅ 1.354ms (SLO: <1.450ms -6.6%) vs baseline: -0.2% Memory: ✅ 64.211MB (SLO: <67.000MB -4.2%) vs baseline: +4.9% ✅ iastTime: ✅ 20.539ms (SLO: <22.250ms -7.7%) vs baseline: +0.2% Memory: ✅ 65.266MB (SLO: <67.000MB -2.6%) vs baseline: +4.8% ✅ profilerTime: ✅ 15.328ms (SLO: <16.550ms -7.4%) vs baseline: +0.8% Memory: ✅ 53.657MB (SLO: <54.500MB 🟡 -1.5%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 20.569ms (SLO: <21.750ms -5.4%) vs baseline: ~same Memory: ✅ 65.360MB (SLO: <67.000MB -2.4%) vs baseline: +4.8% ✅ span-code-originTime: ✅ 26.156ms (SLO: <28.200ms -7.2%) vs baseline: ~same Memory: ✅ 67.421MB (SLO: <69.500MB -3.0%) vs baseline: +4.7% ✅ tracerTime: ✅ 20.450ms (SLO: <21.750ms -6.0%) vs baseline: -0.3% Memory: ✅ 65.287MB (SLO: <67.000MB -2.6%) vs baseline: +4.8% ✅ tracer-and-profilerTime: ✅ 22.087ms (SLO: <23.500ms -6.0%) vs baseline: ~same Memory: ✅ 66.323MB (SLO: <67.500MB 🟡 -1.7%) vs baseline: +4.8% ✅ tracer-dont-create-db-spansTime: ✅ 19.295ms (SLO: <21.500ms 📉 -10.3%) vs baseline: -0.7% Memory: ✅ 65.344MB (SLO: <66.000MB 🟡 -1.0%) vs baseline: +4.8% ✅ tracer-minimalTime: ✅ 16.685ms (SLO: <17.500ms -4.7%) vs baseline: -0.4% Memory: ✅ 65.014MB (SLO: <66.000MB 🟡 -1.5%) vs baseline: +4.3% ✅ tracer-nativeTime: ✅ 20.442ms (SLO: <21.750ms -6.0%) vs baseline: -0.3% Memory: ✅ 71.074MB (SLO: <72.500MB 🟡 -2.0%) vs baseline: +4.6% ✅ tracer-no-cachesTime: ✅ 18.433ms (SLO: <19.650ms -6.2%) vs baseline: -0.1% Memory: ✅ 65.331MB (SLO: <67.000MB -2.5%) vs baseline: +4.8% ✅ tracer-no-databasesTime: ✅ 18.825ms (SLO: <20.100ms -6.3%) vs baseline: ~same Memory: ✅ 64.869MB (SLO: <67.000MB -3.2%) vs baseline: +4.8% ✅ tracer-no-middlewareTime: ✅ 20.217ms (SLO: <21.500ms -6.0%) vs baseline: ~same Memory: ✅ 65.328MB (SLO: <67.000MB -2.5%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.311ms (SLO: <22.000ms -7.7%) vs baseline: -0.1% Memory: ✅ 65.401MB (SLO: <67.000MB -2.4%) vs baseline: +5.0% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 17.989ms (SLO: <19.850ms -9.4%) vs baseline: -0.3% Memory: ✅ 65.213MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.8% ✅ errortracking-enabled-userTime: ✅ 18.224ms (SLO: <19.400ms -6.1%) vs baseline: +1.1% Memory: ✅ 65.169MB (SLO: <66.500MB -2.0%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 18.141ms (SLO: <19.450ms -6.7%) vs baseline: +0.3% Memory: ✅ 65.261MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +5.0% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.953ms (SLO: <4.200ms -5.9%) vs baseline: -0.6% Memory: ✅ 63.260MB (SLO: <66.000MB -4.2%) vs baseline: +4.8% ✅ iast-enabledTime: ✅ 2.454ms (SLO: <2.800ms 📉 -12.4%) vs baseline: -0.1% Memory: ✅ 58.904MB (SLO: <60.000MB 🟡 -1.8%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 2.083ms (SLO: <2.250ms -7.4%) vs baseline: -0.1% Memory: ✅ 52.053MB (SLO: <54.500MB -4.5%) vs baseline: +4.9% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 45.435ms (SLO: <47.150ms -3.6%) vs baseline: +0.4% Memory: ✅ 45.113MB (SLO: <47.000MB -4.0%) vs baseline: +4.7% ✅ add-metricsTime: ✅ 320.491ms (SLO: <344.800ms -7.1%) vs baseline: +0.2% Memory: ✅ 553.791MB (SLO: <562.000MB 🟡 -1.5%) vs baseline: +4.8% ✅ add-tagsTime: ✅ 294.018ms (SLO: <314.000ms -6.4%) vs baseline: +1.1% Memory: ✅ 554.955MB (SLO: <563.500MB 🟡 -1.5%) vs baseline: +4.9% ✅ get-contextTime: ✅ 82.425ms (SLO: <92.350ms 📉 -10.7%) vs baseline: -0.2% Memory: ✅ 40.258MB (SLO: <46.500MB 📉 -13.4%) vs baseline: +5.0% ✅ is-recordingTime: ✅ 43.068ms (SLO: <44.500ms -3.2%) vs baseline: +0.4% Memory: ✅ 44.562MB (SLO: <47.500MB -6.2%) vs baseline: +5.0% ✅ record-exceptionTime: ✅ 62.231ms (SLO: <67.650ms -8.0%) vs baseline: +0.3% Memory: ✅ 40.490MB (SLO: <47.000MB 📉 -13.9%) vs baseline: +4.9% ✅ set-statusTime: ✅ 48.952ms (SLO: <50.400ms -2.9%) vs baseline: +0.5% Memory: ✅ 44.600MB (SLO: <47.000MB -5.1%) vs baseline: +5.2% ✅ startTime: ✅ 42.285ms (SLO: <43.450ms -2.7%) vs baseline: +0.3% Memory: ✅ 44.523MB (SLO: <47.000MB -5.3%) vs baseline: +5.0% ✅ start-finishTime: ✅ 83.445ms (SLO: <88.000ms -5.2%) vs baseline: +0.4% Memory: ✅ 34.544MB (SLO: <46.500MB 📉 -25.7%) vs baseline: +4.8% ✅ start-finish-telemetryTime: ✅ 84.813ms (SLO: <89.000ms -4.7%) vs baseline: +0.2% Memory: ✅ 34.564MB (SLO: <46.500MB 📉 -25.7%) vs baseline: +4.8% ✅ update-nameTime: ✅ 45.232ms (SLO: <45.150ms +0.2%) vs baseline: +1.8% Memory: ✅ 44.811MB (SLO: <47.000MB -4.7%) vs baseline: +4.9%
|
2 participants
Backport 7cd4d9c from #14794 to 3.15.
Description
Currently, in Test Impact Analysis code coverage, we use
is_user_code()to decide whether to instrument a module. This function was conceived for use in non-CI contexts where user code may be installed in site-packages like external dependencies. This is not necessary in Test Optimization, where we only want to cover code inside the current repo (TIA only works with filenames that are relative to the repo root, and we already set the repo root as the include path ofModuleCodeCollector). Removing this check also resolves a bug where test packages are incorrectly detected as third-party if a third-party package contains files undertest/*ortests/*that get installed at site-packages level (sumyandsendgriddo this, for instance).Testing
Unit tests + manual testing in dogweb.
Risks
Potentially covering more code than expected. Should not be an issue because we already exclude site-packages and similar here.
Additional Notes
None.