-
Notifications
You must be signed in to change notification settings - Fork 461
chore(codeowners): assign contrib, test, and snapshot files apm-serverless codeowner #14795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
duncanpharvey
wants to merge
5
commits into
main
Choose a base branch
from
duncan-harvey/apm-serverless-codeowners
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+17
−2
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8ab730e
assign contrib, test, and snapshot files apm-serverless codeowner
duncanpharvey c7be93f
Apply suggestion from @brettlangdon
duncanpharvey 34de6cc
fix formatting
duncanpharvey ca7ce4c
include all serverless directories with correct paths in codeowners
duncanpharvey f6ac53b
Merge branch 'main' into duncan-harvey/apm-serverless-codeowners
brettlangdon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this line removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests/internal/test_serverless.pywas moved:dd-trace-py/.github/CODEOWNERS
Line 239 in 34de6cc
tests/contrib/aws_lambdawas changed totests/contrib/internal/aws_lambdasince thetests/contrib/aws_lambdadirectory no longer existsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
tests/contrib/aws_lambdadir definitely still exists: https://github.com/DataDog/dd-trace-py/tree/main/tests/contrib/aws_lambdaThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My mistake, I applied the
internalsubdirectory that is underddtracetotestsas well. I updated the tests directories to be correct (tests/contrib/*) in addition to addingddtrace/contrib/internal/aws_lambdato the list of directories with an apm-serverless codeowner.